Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314283: Support for NSS tests on aarch64 platforms #2284

Closed

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Mar 11, 2024

I backport this for parity with 17.0.11-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8314283 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8314283: Support for NSS tests on aarch64 platforms (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2284/head:pull/2284
$ git checkout pull/2284

Update a local copy of the PR:
$ git checkout pull/2284
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2284

View PR using the GUI difftool:
$ git pr show -t 2284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2284.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2a8016096000de5836251f2ca9bc8ad6479e6942 8314283: Support for NSS tests on aarch64 platforms Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314283: Support for NSS tests on aarch64 platforms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • a14f845: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • f8cfa35: 8319372: C2 compilation fails with "Bad immediate dominator info"
  • 2d8a3a8: 8301381: Verify DTLS 1.0 cannot be negotiated
  • dd94e20: 8256660: Disable DTLS 1.0
  • f38add6: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
  • 4ba565c: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • e148b99: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
  • 61fed7b: 8315677: Open source few swing JFileChooser and other tests
  • f196e02: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
  • 833e2bb: 8291753: Add JFR event for GC CPU Time

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 12, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

Going to push as commit 3433fdb.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 0606e5a: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • a22ac46: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
  • a14f845: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • f8cfa35: 8319372: C2 compilation fails with "Bad immediate dominator info"
  • 2d8a3a8: 8301381: Verify DTLS 1.0 cannot be negotiated
  • dd94e20: 8256660: Disable DTLS 1.0
  • f38add6: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
  • 4ba565c: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • e148b99: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
  • 61fed7b: 8315677: Open source few swing JFileChooser and other tests
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/f221ff38300b5513a06e5755469668ef83556a3a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2024
@openjdk openjdk bot closed this Mar 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@luchenlin Pushed as commit 3433fdb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant