Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 #2287

Closed

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Mar 12, 2024

I backport this for parity with 17.0.11-oracle.
Follow 21-dev backport.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8319128 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8319136 needs maintainer approval

Issues

  • JDK-8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 (Bug - P3 - Approved)
  • JDK-8319136: Skip pkcs11 tests on linux-aarch64 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2287/head:pull/2287
$ git checkout pull/2287

Update a local copy of the PR:
$ git checkout pull/2287
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2287/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2287

View PR using the GUI difftool:
$ git pr show -t 2287

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2287.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1f9b03e597d87679964e8772c6bea538c74feb2c 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added the backport label Mar 12, 2024
@luchenlin
Copy link
Author

/issue JDK-8319136

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@luchenlin
Updating description of additional solved issue: 8319136: Skip pkcs11 tests on linux-aarch64.

@mlbridge
Copy link

mlbridge bot commented Mar 12, 2024

Webrevs

# Conflicts:
#	test/jdk/sun/security/pkcs11/PKCS11Test.java
@openjdk openjdk bot added the clean label Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
8319136: Skip pkcs11 tests on linux-aarch64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 49c260d: 8315898: Open source swing JMenu tests
  • b632518: 8299858: [Metrics] Swap memory limit reported incorrectly when too large

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 13, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

Going to push as commit 02ef1c7.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 09ebd1c: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 49c260d: 8315898: Open source swing JMenu tests
  • b632518: 8299858: [Metrics] Swap memory limit reported incorrectly when too large

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 13, 2024
@openjdk openjdk bot closed this Mar 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@luchenlin Pushed as commit 02ef1c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant