Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324598: use mem_unit when working with sysinfo memory and swap related information #2290

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Mar 12, 2024


Progress

  • Change must not contain extraneous whitespace
  • JDK-8324598 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8324598: use mem_unit when working with sysinfo memory and swap related information (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2290/head:pull/2290
$ git checkout pull/2290

Update a local copy of the PR:
$ git checkout pull/2290
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2290/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2290

View PR using the GUI difftool:
$ git pr show -t 2290

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2290.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7a798d3cebea0915f8a73af57333b3488c2091af 8324598: use mem_unit when working with sysinfo memory and swap related information Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Mar 12, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324598: use mem_unit when working with sysinfo memory and swap related information

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 49c260d: 8315898: Open source swing JMenu tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 13, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

Going to push as commit 6488725.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 02ef1c7: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
  • 09ebd1c: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 49c260d: 8315898: Open source swing JMenu tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 13, 2024
@openjdk openjdk bot closed this Mar 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@MBaesken Pushed as commit 6488725.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant