-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8290901: Reduce use of -source in langtools tests #2297
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/clean |
@GoeLin This backport pull request is now marked as clean |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
GHA failure: Risc-V compile setup failed, unrelated. |
/integrate |
Going to push as commit 7d716fc.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.12-oracle.
Applies clean except for patch of InstanceofTotalPattern.java which is a test that came with new feature "8282274: Compiler implementation for Pattern Matching for switch (Third Preview)".
Will mark clean.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2297/head:pull/2297
$ git checkout pull/2297
Update a local copy of the PR:
$ git checkout pull/2297
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2297/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2297
View PR using the GUI difftool:
$ git pr show -t 2297
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2297.diff
Webrev
Link to Webrev Comment