Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281168: Micro-optimize VarForm.getMemberName for interpreter #230

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 10, 2022

Clean backport to improve interpreter performance.

Additional testing:

  • Linux x86_64 fastdebug tier1

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8281168: Micro-optimize VarForm.getMemberName for interpreter

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/230/head:pull/230
$ git checkout pull/230

Update a local copy of the PR:
$ git checkout pull/230
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/230/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 230

View PR using the GUI difftool:
$ git pr show -t 230

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/230.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fc77217814eb1a346d7380299abdc2b01a69b4de 8281168: Micro-optimize VarForm.getMemberName for interpreter Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281168: Micro-optimize VarForm.getMemberName for interpreter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 863631f: 8282225: GHA: Allow one concurrent run per PR only
  • d5e4f03: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
  • feeb418: 8272146: Disable Fibonacci test on memory constrained systems
  • d3dc0cd: 8279515: C1: No inlining through invokedynamic and invokestatic call sites when resolved class is not linked
  • d413469: 8272169: runtime/logging/LoaderConstraintsTest.java doesn't build test.Empty
  • f79a4ed: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • 6fb49c3: 8269753: Misplaced caret in PatternSyntaxException's detail message
  • eb076ae: 8270336: [TESTBUG] Fix initialization in NonbranchyTree
  • 722964b: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support
  • 1e25ca9: 8270837: fix typos in test TestSigParse.java
  • ... and 5 more: https://git.openjdk.java.net/jdk17u-dev/compare/0d933c9b4f096c55058209ab7eaa8588bdc95ffb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2022

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2022

Going to push as commit c82e18f.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 5edb982: 8279668: x86: AVX2 versions of vpxor should be asserted
  • bb8b3c2: 8279958: Provide configure hints for Alpine/apk package managers
  • 3c6aecd: 8276657: XSLT compiler tries to define a class with empty name
  • 79cce16: 8276825: hotspot/runtime/SelectionResolution test errors
  • 972dcde: 8276260: (se) Remove java/nio/channels/Selector/Wakeup.java from ProblemList (win)
  • 535511a: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
  • 3b53635: 8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout
  • fb3ccbc: 8274244: ReportOnImportedModuleAnnotation.java fails on rerun
  • e2fa3d3: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines
  • 08084ea: 8274233: Minor cleanup for ToolBox
  • ... and 17 more: https://git.openjdk.java.net/jdk17u-dev/compare/0d933c9b4f096c55058209ab7eaa8588bdc95ffb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2022
@openjdk openjdk bot closed this Mar 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@shipilev Pushed as commit c82e18f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8281168-varform-interp branch April 6, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant