Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8015739: Background of JInternalFrame is located out of JInternalFrame #2301

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 18, 2024

I backport this for parity with 17.0.12-oracle.

Resolved Copyright, will mark clean if needed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8015739 needs maintainer approval

Issue

  • JDK-8015739: Background of JInternalFrame is located out of JInternalFrame (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2301/head:pull/2301
$ git checkout pull/2301

Update a local copy of the PR:
$ git checkout pull/2301
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2301/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2301

View PR using the GUI difftool:
$ git pr show -t 2301

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2301.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8015739: Background of JInternalFrame is located out of JInternalFrame

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f857f795a9fc8b116bfc6b039114051061950e28 8015739: Background of JInternalFrame is located out of JInternalFrame Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 18, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 19, 2024

GHA failure Risc-V compile setup problem. Unrelated.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 19, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 19, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

Going to push as commit 7fb1fb0.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 19, 2024
@openjdk openjdk bot closed this Mar 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@GoeLin Pushed as commit 7fb1fb0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8015739 branch March 19, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant