8159927: Add a test to verify JMOD files created in the images do not have debug symbols

[SoniaZaldana]

Hi all,

This PR contains a backport of 6c0bebccb0092d9726eb89a054e023e92edf7ca6.

Patch is not clean. Test won't build in 17 because it can't find import jdk.internal.util.OperatingSystem.

This class was introduced in 21 as part of JDK-8303485.

I've worked around that by removing the dependency to that utility function and checking the operating system with System.getProperty("os.name").

Testing:

• Added test case passes

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8159927 needs maintainer approval

Issue

• JDK-8159927: Add a test to verify JMOD files created in the images do not have debug symbols (Enhancement - P4 - Approved)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2305/head:pull/2305
$ git checkout pull/2305

Update a local copy of the PR:
$ git checkout pull/2305
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2305/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2305

View PR using the GUI difftool:
$ git pr show -t 2305

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2305.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8159927: Add a test to verify JMOD files created in the images do not have debug symbols

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 10b427d: 8329570: G1: Excessive is_obj_dead_cond calls in verification
• f70558d: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
• 9912666: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
• aa9c12b: 8315609: Open source few more swing text/html tests
• 2d27c94: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• c3438a5: 8305874: Open source AWT Key, Text Event related tests
• 94caa64: 8187759: Background not refreshed when painting over a transparent JFrame
• fbd0088: 8306634: Open source AWT Event related tests
• 7d19575: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
• 80273fa: 8316242: Opensource SwingGraphics manual test
• ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/c741b359000ee2c5fe6cfc6a1c43057d95c344aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealLucy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[SoniaZaldana]

GHA Failures:

• Unrelated RISC-V failure.
• Unrelated test failures: java/lang/String/StringRepeat.java in jdk/tier1 part1. I'm seeing these failures intermittently across all PRs.

[mlbridge]

Webrevs

• 01: Full - Incremental (11a19887)
• 00: Full (7f305438)

[GoeLin]

Hi @SoniaZaldana, did you see the comment in the JBS issue?

[SoniaZaldana]

Hi @GoeLin, I saw it. I added follow up PRs for both 17u and 21u. Thanks :)

[bridgekeeper]

@SoniaZaldana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[amosshi]

SAP nightlies passed on 2024-04-17,19,20

• Automated jtreg test: jtreg_jdk_tier1
• jdk/modules/etc/JmodExcludedFiles.java: SUCCESSFUL GitHub 📊⏲ - [325 msec]

[amosshi]

Hi @SoniaZaldana

• Would you please re-trigger the OpenJDK GHA Sanity Checks since now we see some errors - although it looks to me not caused by current PR
• I tried to re-trigger it well I don't have the permission to re-trigger.

[RealLucy]

LGTM.

[openjdk]

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[amosshi]

/approval request "Backporting for parity with 17.0.12-oracle. Un-Clean backport. SAP nightlies passed on 2024-04-17,19,20”

[openjdk]

@amosshi Only the author (@SoniaZaldana) is allowed to issue the /approval command.

[SoniaZaldana]

/integrate

[openjdk]

@SoniaZaldana
Your change (at version 11a1988) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit 9b2f521.
Since your change was applied there have been 21 commits pushed to the master branch:

• 54e0120: 8301753: AppendFile/WriteFile has differences between make 3.81 and 4+
• 3f5e536: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
• bcc83cd: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes
• b13cb2f: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
• 3324133: 8318854: [macos14] Running any AWT app prints Secure coding warning
• 10b427d: 8329570: G1: Excessive is_obj_dead_cond calls in verification
• f70558d: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
• 9912666: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
• aa9c12b: 8315609: Open source few more swing text/html tests
• 2d27c94: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• ... and 11 more: https://git.openjdk.org/jdk17u-dev/compare/c741b359000ee2c5fe6cfc6a1c43057d95c344aa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @SoniaZaldana Pushed as commit 9b2f521.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.