Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280546: Remove hard-coded 127.0.0.1 loopback address #2315

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 20, 2024

I backport this for parity with 17.0.12-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8280546 needs maintainer approval

Issue

  • JDK-8280546: Remove hard-coded 127.0.0.1 loopback address (Sub-task - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2315/head:pull/2315
$ git checkout pull/2315

Update a local copy of the PR:
$ git checkout pull/2315
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2315/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2315

View PR using the GUI difftool:
$ git pr show -t 2315

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2315.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280546: Remove hard-coded 127.0.0.1 loopback address

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • b4d22f6: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition
  • 56ed749: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • 6700a49: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection
  • d554437: 8315663: Open source misc awt tests
  • 9922f22: 8314832: Few runtime/os tests ignore vm flags
  • 6359b28: 8324632: Update Zlib Data Compression Library to Version 1.3.1
  • a8a8128: 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner
  • 09f3890: 8297449: Update JInternalFrame Metal Border code
  • aa2cdb3: 8322503: Shenandoah: Clarify gc state usage
  • c0d209c: 8313307: java/util/Formatter/Padding.java fails on some Locales

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b5de2cc9d36e1fad7d0bf70f7c83ff829e16b7f3 8280546: Remove hard-coded 127.0.0.1 loopback address Mar 20, 2024
@openjdk
Copy link

openjdk bot commented Mar 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 20, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 20, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 21, 2024

GHA failure: Risc-V sysroot issue. Unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Mar 22, 2024

GHA failure Risc-V compile setup problem. Unrelated.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 22, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 25, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

Going to push as commit 432210b.
Since your change was applied there have been 11 commits pushed to the master branch:

  • d74ef51: 8260540: serviceability/jdwp/AllModulesCommandTest.java failed with "Debuggee error: 'ERROR: transport error 202: bind failed: Address already in use'"
  • b4d22f6: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition
  • 56ed749: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • 6700a49: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection
  • d554437: 8315663: Open source misc awt tests
  • 9922f22: 8314832: Few runtime/os tests ignore vm flags
  • 6359b28: 8324632: Update Zlib Data Compression Library to Version 1.3.1
  • a8a8128: 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner
  • 09f3890: 8297449: Update JInternalFrame Metal Border code
  • aa2cdb3: 8322503: Shenandoah: Clarify gc state usage
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/e3ba201fe489d37d290338eff07bd85fbb0a4310...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2024
@openjdk openjdk bot closed this Mar 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@GoeLin Pushed as commit 432210b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant