-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8326529: JFR: Test for CompilerCompile events fails due to time out #2323
8326529: JFR: Test for CompilerCompile events fails due to time out #2323
Conversation
👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into |
@roberttoyonaga This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 94 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for the backport of a JFR test case fix. Should be very low risk. Clean backport. |
@roberttoyonaga |
@roberttoyonaga, did you check the failing tests? |
Hi @GoeLin, yes I had a look at them, but both don't seem to be related to these new changes.
I had a quick look at some other recent PRs, and it seems like these test fail for them too for the same reasons. I'm not sure, but maybe something has changed in the testing infrastructure to cause them to be misconfigured? |
/integrate |
@roberttoyonaga |
I believe GHA failures are unrelated. /sponsor |
Going to push as commit 7ced722.
Your commit was automatically rebased without conflicts. |
@shipilev @roberttoyonaga Pushed as commit 7ced722. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a backport of openjdk/jdk@4dd6c44
This backport limits compilation only to the test methods TestCompileCompile cares about. It should help resolve some test failures for Adoptium (see adoptium/aqa-tests#3046).
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2323/head:pull/2323
$ git checkout pull/2323
Update a local copy of the PR:
$ git checkout pull/2323
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2323/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2323
View PR using the GUI difftool:
$ git pr show -t 2323
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2323.diff
Webrev
Link to Webrev Comment