Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326529: JFR: Test for CompilerCompile events fails due to time out #2323

Conversation

roberttoyonaga
Copy link
Contributor

@roberttoyonaga roberttoyonaga commented Mar 22, 2024

This is a backport of openjdk/jdk@4dd6c44

This backport limits compilation only to the test methods TestCompileCompile cares about. It should help resolve some test failures for Adoptium (see adoptium/aqa-tests#3046).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326529 needs maintainer approval

Issue

  • JDK-8326529: JFR: Test for CompilerCompile events fails due to time out (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2323/head:pull/2323
$ git checkout pull/2323

Update a local copy of the PR:
$ git checkout pull/2323
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2323/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2323

View PR using the GUI difftool:
$ git pr show -t 2323

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2323.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2024

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@roberttoyonaga This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326529: JFR: Test for CompilerCompile events fails due to time out

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

  • 533e1b1: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960
  • 791be77: 8328705: GHA: Cross-compilation jobs do not require build JDK
  • 432210b: 8280546: Remove hard-coded 127.0.0.1 loopback address
  • d74ef51: 8260540: serviceability/jdwp/AllModulesCommandTest.java failed with "Debuggee error: 'ERROR: transport error 202: bind failed: Address already in use'"
  • b4d22f6: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition
  • 56ed749: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • 6700a49: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection
  • d554437: 8315663: Open source misc awt tests
  • 9922f22: 8314832: Few runtime/os tests ignore vm flags
  • 6359b28: 8324632: Update Zlib Data Compression Library to Version 1.3.1
  • ... and 84 more: https://git.openjdk.org/jdk17u-dev/compare/e8f7eaeefe503a34089fd49051f9114d98a63cb1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 8326529: JFR: Test for CompilerCompile events fails due to time out Mar 22, 2024
@openjdk
Copy link

openjdk bot commented Mar 22, 2024

This backport pull request has now been updated with issue from the original commit.

@roberttoyonaga roberttoyonaga marked this pull request as ready for review March 22, 2024 19:20
@openjdk
Copy link

openjdk bot commented Mar 22, 2024

⚠️ @roberttoyonaga This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2024

Webrevs

@roberttoyonaga
Copy link
Contributor Author

/approval request for the backport of a JFR test case fix. Should be very low risk. Clean backport.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@roberttoyonaga
8326529: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 22, 2024
@GoeLin
Copy link
Member

GoeLin commented Mar 25, 2024

@roberttoyonaga, did you check the failing tests?

@roberttoyonaga
Copy link
Contributor Author

roberttoyonaga commented Mar 25, 2024

did you check the failing tests?

Hi @GoeLin, yes I had a look at them, but both don't seem to be related to these new changes.

  • linux-cross-compile fails "while configuring base packages" for riscv.
  • linux-x86 / test - Test (tier1) fails on the test: java/lang/String/StringRepeat.java with an error message:
    Error occurred during initialization of VM Could not reserve enough space for 2097152KB object heap. This seems like it's related to the environment not the PR itself.

I had a quick look at some other recent PRs, and it seems like these test fail for them too for the same reasons. I'm not sure, but maybe something has changed in the testing infrastructure to cause them to be misconfigured?

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 26, 2024
@roberttoyonaga
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@roberttoyonaga
Your change (at version 08c9d46) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Apr 2, 2024

I believe GHA failures are unrelated.

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

Going to push as commit 7ced722.
Since your change was applied there have been 119 commits pushed to the master branch:

  • 08debe8: 8306040: HttpResponseInputStream.available() returns 1 on empty stream
  • 78f482d: 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests
  • 5ecac7a: 8280377: MethodHandleProxies does not correctly invoke default methods with varags
  • 4ececad: 8306714: Open source few Swing event and AbstractAction tests
  • 151091c: 8305942: Open source several AWT Focus related tests
  • 996dfb0: 8305943: Open source few AWT Focus related tests
  • 615c01b: 8297292: java/nio/channels/FileChannel/FileExtensionAndMap.java is too slow
  • 8e132c4: 8163229: several regression tests have a main method that is never executed
  • 7680369: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"
  • e59eeb0: 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test
  • ... and 109 more: https://git.openjdk.org/jdk17u-dev/compare/e8f7eaeefe503a34089fd49051f9114d98a63cb1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 2, 2024
@openjdk openjdk bot closed this Apr 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@shipilev @roberttoyonaga Pushed as commit 7ced722.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants