Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320005: Allow loading of shared objects with .a extension on AIX #2326

Conversation

suchismith1993
Copy link

@suchismith1993 suchismith1993 commented Mar 25, 2024

Hi all,

This pull request contains a backport of commit e85355ad from the openjdk/jdk repository.

The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320005 needs maintainer approval

Issue

  • JDK-8320005: Allow loading of shared objects with .a extension on AIX (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2326/head:pull/2326
$ git checkout pull/2326

Update a local copy of the PR:
$ git checkout pull/2326
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2326/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2326

View PR using the GUI difftool:
$ git pr show -t 2326

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2326.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2024

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab 8320005: Allow loading of shared objects with .a extension on AIX Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 25, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2024

Webrevs

@openjdk openjdk bot added rfr Pull request is ready for review and removed rfr Pull request is ready for review labels Mar 25, 2024
@suchismith1993 suchismith1993 deleted the backport-suchismith1993-e85355ad branch March 26, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant