Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328165: improve assert(idx < _maxlrg) failed: oob #2327

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Mar 25, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328165 needs maintainer approval

Issue

  • JDK-8328165: improve assert(idx < _maxlrg) failed: oob (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2327/head:pull/2327
$ git checkout pull/2327

Update a local copy of the PR:
$ git checkout pull/2327
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2327/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2327

View PR using the GUI difftool:
$ git pr show -t 2327

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2327.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328165: improve assert(idx < _maxlrg) failed: oob

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 4ced080: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868
  • d2df108: 8286045: Use ForceGC for cleaner test cases
  • ba77d0b: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains
  • a6180f7: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac
  • 9b9573f: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"
  • 0dce546: 8295944: Move the Http2TestServer and related classes into a package of its own
  • f6c87d8: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • b293856: 8323994: gtest runner repeats test name for every single gtest assertion
  • f52725d: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm"
  • 91ac085: 8328825: Google CAInterop test failures
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/b4d22f6f3522963e123d58e59c6d9680ad2bf1c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d57bdd85ab5e45a2ecfce0c022da067ac30bb80d 8328165: improve assert(idx < _maxlrg) failed: oob Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 28, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Apr 1, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

Going to push as commit 1e777ec.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 45de685: 8320005: Allow loading of shared objects with .a extension on AIX
  • e82d936: 8328812: Update and move siphash license
  • 4ced080: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868
  • d2df108: 8286045: Use ForceGC for cleaner test cases
  • ba77d0b: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains
  • a6180f7: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac
  • 9b9573f: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"
  • 0dce546: 8295944: Move the Http2TestServer and related classes into a package of its own
  • f6c87d8: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • b293856: 8323994: gtest runner repeats test name for every single gtest assertion
  • ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/b4d22f6f3522963e123d58e59c6d9680ad2bf1c9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2024
@openjdk openjdk bot closed this Apr 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2024
@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@MBaesken Pushed as commit 1e777ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant