Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 #2328

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Mar 25, 2024

Hi all,

This pull request contains a backport of JDK-8185862 from commit dcca5daa from the openjdk/jdk22u repository.

I had to resolve copyrights in awt_Win32GraphicsDevice.cpp and awt_Win32GraphicsEnv.cpp plus a comment diff in Devices.h due to missing JDK-8301443, will mark as clean.

Thanks
Christoph


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8185862 needs maintainer approval

Issue

  • JDK-8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2328/head:pull/2328
$ git checkout pull/2328

Update a local copy of the PR:
$ git checkout pull/2328
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2328/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2328

View PR using the GUI difftool:
$ git pr show -t 2328

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2328.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

  • c758755: 8315834: Open source several Swing JSpinner related tests
  • fc01ffe: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • c430b11: 8305645: System Tray icons get corrupted when Windows primary monitor changes
  • cb1a03c: 8325432: enhance assert message "relocation addr must be in this section"
  • 7217328: 8315652: RISC-V: Features string uses wrong separator for jtreg
  • 62e6dfa: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
  • 989e0bf: 8310818: Refactor more Locale tests to use JUnit
  • 533fac6: 8328638: Fallback option for POST-only OCSP requests
  • 31ba7e0: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
  • b96339f: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
  • ... and 47 more: https://git.openjdk.org/jdk17u-dev/compare/b4d22f6f3522963e123d58e59c6d9680ad2bf1c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport dcca5daaf7f51c6579369c6ba3430a3d7962dbf2 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 25, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2024

Webrevs

@openjdk openjdk bot added the approval label Mar 31, 2024
@RealCLanger
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label Apr 11, 2024
@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@RealCLanger This backport pull request is now marked as clean

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 11, 2024
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

Going to push as commit 1ae82df.
Since your change was applied there have been 58 commits pushed to the master branch:

  • 85e3f1a: 8316608: Enable parallelism in vmTestbase/gc/vector tests
  • c758755: 8315834: Open source several Swing JSpinner related tests
  • fc01ffe: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • c430b11: 8305645: System Tray icons get corrupted when Windows primary monitor changes
  • cb1a03c: 8325432: enhance assert message "relocation addr must be in this section"
  • 7217328: 8315652: RISC-V: Features string uses wrong separator for jtreg
  • 62e6dfa: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
  • 989e0bf: 8310818: Refactor more Locale tests to use JUnit
  • 533fac6: 8328638: Fallback option for POST-only OCSP requests
  • 31ba7e0: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
  • ... and 48 more: https://git.openjdk.org/jdk17u-dev/compare/b4d22f6f3522963e123d58e59c6d9680ad2bf1c9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2024
@openjdk openjdk bot closed this Apr 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 11, 2024
@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@RealCLanger Pushed as commit 1ae82df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the backport-RealCLanger-dcca5daa branch April 11, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant