Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320005: Allow loading of shared objects with .a extension on AIX #2332

Conversation

suchismith1993
Copy link

@suchismith1993 suchismith1993 commented Mar 26, 2024

Hi all,

This pull request contains a backport of commit e85355ad from the openjdk/jdk repository.

The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320005 needs maintainer approval

Issue

  • JDK-8320005: Allow loading of shared objects with .a extension on AIX (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2332/head:pull/2332
$ git checkout pull/2332

Update a local copy of the PR:
$ git checkout pull/2332
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2332/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2332

View PR using the GUI difftool:
$ git pr show -t 2332

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2332.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 26, 2024

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@suchismith1993 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320005: Allow loading of shared objects with .a extension on AIX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

  • e82d936: 8328812: Update and move siphash license
  • 4ced080: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868
  • d2df108: 8286045: Use ForceGC for cleaner test cases
  • ba77d0b: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains
  • a6180f7: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac
  • 9b9573f: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"
  • 0dce546: 8295944: Move the Http2TestServer and related classes into a package of its own
  • f6c87d8: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • b293856: 8323994: gtest runner repeats test name for every single gtest assertion
  • f52725d: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm"
  • ... and 57 more: https://git.openjdk.org/jdk17u-dev/compare/fa8a159933a1c5c4fb5f03b2b78eedc864881731...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab 8320005: Allow loading of shared objects with .a extension on AIX Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 26, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 26, 2024

Webrevs

Restore comments.
@openjdk
Copy link

openjdk bot commented Mar 27, 2024

⚠️ @suchismith1993 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@suchismith1993
Copy link
Author

/approval request This back port is required to handle dynamic libraries of AIX.

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@suchismith1993
8320005: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 27, 2024
@suchismith1993
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 1, 2024
@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@suchismith1993
Your change (at version 463e01b) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

Going to push as commit 45de685.
Since your change was applied there have been 67 commits pushed to the master branch:

  • e82d936: 8328812: Update and move siphash license
  • 4ced080: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868
  • d2df108: 8286045: Use ForceGC for cleaner test cases
  • ba77d0b: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains
  • a6180f7: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac
  • 9b9573f: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"
  • 0dce546: 8295944: Move the Http2TestServer and related classes into a package of its own
  • f6c87d8: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • b293856: 8323994: gtest runner repeats test name for every single gtest assertion
  • f52725d: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm"
  • ... and 57 more: https://git.openjdk.org/jdk17u-dev/compare/fa8a159933a1c5c4fb5f03b2b78eedc864881731...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2024
@openjdk openjdk bot closed this Apr 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 1, 2024
@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@TheRealMDoerr @suchismith1993 Pushed as commit 45de685.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants