8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains

[GoeLin]

I had to do some trivial resolves.

I add some refactorings from "8262912: ciReplay: replay does not simulate unresolved classes"
to the edited test files to make the test compile. I also had to fix the path to WhiteBox.

I also added two methods to query names to ciEnv from
"8271911: replay compilations of methods which use JSR292 (easy cases)".
this calls further into dyno_name(). I disabled this, it is not needed as long as 8262912 is not backported.

Test reproduces the issue as expected.

For follow up 8276227 see dependent pull request.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8275868 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains (Bug - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2334/head:pull/2334
$ git checkout pull/2334

Update a local copy of the PR:
$ git checkout pull/2334
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2334/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2334

View PR using the GUI difftool:
$ git pr show -t 2334

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2334.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• f6c87d8: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
• b293856: 8323994: gtest runner repeats test name for every single gtest assertion
• f52725d: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm"
• 91ac085: 8328825: Google CAInterop test failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (a7b0185e)
• 00: Full (60bf4ada)

[TheRealMDoerr]

Looks basically good. Please see my suggestions.

[TheRealMDoerr]

Ok. Thanks for the update.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

/integrate

[openjdk]

Going to push as commit ba77d0b.
Since your change was applied there have been 7 commits pushed to the master branch:

• a6180f7: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac
• 9b9573f: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"
• 0dce546: 8295944: Move the Http2TestServer and related classes into a package of its own
• f6c87d8: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
• b293856: 8323994: gtest runner repeats test name for every single gtest assertion
• f52725d: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm"
• 91ac085: 8328825: Google CAInterop test failures

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit ba77d0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.