8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868

[GoeLin]

I had to do a trivial resolve in ciReplay and adapt the path to WhiteBox in the test.

Follow up for 8275868.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8276227 needs maintainer approval

Issue

• JDK-8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868 (Bug - P3 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer) ⚠️ Review applies to 83ace890

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2335/head:pull/2335
$ git checkout pull/2335

Update a local copy of the PR:
$ git checkout pull/2335
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2335/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2335

View PR using the GUI difftool:
$ git pr show -t 2335

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2335.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/2334 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full (5324de4d)
• 02: Full - Incremental (3a3124b2)
• 01: Full - Incremental (372116be)
• 00: Full (83ace890)

[TheRealMDoerr]

LGTM. Please consider inserting the empty line before integrating.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8276227
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@GoeLin this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout goetz_backport_8276227
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[GoeLin]

/integrate

[openjdk]

Going to push as commit 4ced080.
Since your change was applied there has been 1 commit pushed to the master branch:

• d2df108: 8286045: Use ForceGC for cleaner test cases

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 4ced080.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.