Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328638: Fallback option for POST-only OCSP requests #2338

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 27, 2024

Improves JDK OCSP compatibility with some real world OCSP responders. Starts to be a problem since JDK 17 introduced GET OCSP requests. The default behavior is not changed.

The backports are almost clean, I just had to add the import for Locale and Debug in one of the files. Locale is added in mainline by JDK-8312443, which I do not want to backport at the moment, as it changes existing security code. Debug is added by JDK-8179502, which is also not amenable for easy backporting.

Additional testing:

  • jdk_security pass, includes new test cases

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8328810 to be approved
  • JDK-8328638 needs maintainer approval
  • JDK-8329213 needs maintainer approval

Issues

  • JDK-8328638: Fallback option for POST-only OCSP requests (Enhancement - P4 - Approved)
  • JDK-8329213: Better validation for com.sun.security.ocsp.useget option (Enhancement - P4 - Approved)
  • JDK-8328810: Fallback option for POST-only OCSP requests (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2338/head:pull/2338
$ git checkout pull/2338

Update a local copy of the PR:
$ git checkout pull/2338
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2338/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2338

View PR using the GUI difftool:
$ git pr show -t 2338

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2338.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 27, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328638: Fallback option for POST-only OCSP requests
8329213: Better validation for com.sun.security.ocsp.useget option

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 31ba7e0: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
  • b96339f: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
  • 261e45a: 8306031: Update IANA Language Subtag Registry to Version 2023-04-13
  • 3764735: 8295026: Remove unused fields in StyleSheet
  • e789a67: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 1b72e51: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • fbcb399: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 9a0e875: 8307411: Test java/foreign/channels/TestAsyncSocketChannels.java failed: IllegalStateException: Already closed
  • e913fa7: 8303457: Introduce convenience test library APIs for creating test servers for tests in test/jdk/java/net/httpclient
  • 7a47adf: 8290126: Add a check in JavadocTester for "javadoc should not crash"
  • ... and 13 more: https://git.openjdk.org/jdk17u-dev/compare/4ececadadd3d75d5468c77ff1fab0723b19ad497...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 614db2ea9e10346475eef34629eab54878aa482d 8328638: Fallback option for POST-only OCSP requests Mar 27, 2024
@openjdk
Copy link

openjdk bot commented Mar 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean and removed clean labels Mar 27, 2024
@shipilev shipilev force-pushed the JDK-8328638-ocsp-fallback-get branch from 665592a to c557047 Compare April 2, 2024 09:21
@shipilev
Copy link
Member Author

shipilev commented Apr 2, 2024

/issue add JDK-8329213

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@shipilev
Adding additional issue to issue list: 8329213: Better validation for com.sun.security.ocsp.useget option.

@shipilev shipilev marked this pull request as ready for review April 2, 2024 10:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 2, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

shipilev commented Apr 2, 2024

/approval 8328638 request Improves JDK OCSP compatibility with some real world OCSP responders. Starts to be a problem since JDK 17 introduced GET OCSP requests. Risk is medium-low, as default behavior is not changed, and the code is simple. Passes full jdk_security tests, eyeballed logs show the expected behavior.

/approval 8329213 request Option checking followup for JDK-8328638. Risk is low, simple refactoring. Passes full jdk_security tests, eyeballed logs show the expected behavior.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@shipilev
8328638: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@shipilev
8329213: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 2, 2024
@shipilev
Copy link
Member Author

shipilev commented Apr 5, 2024

@jerboaa, @RealCLanger -- what do you think about this one? Would be nice to unblock JDK 17 for folks.

@RealCLanger
Copy link
Contributor

Makes sense.

/approve

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@RealCLanger usage: /approve [<id>] (yes|no)

@RealCLanger
Copy link
Contributor

/approve yes

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@RealCLanger
8328638: The approval request has been approved.
8329213: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 5, 2024
@shipilev
Copy link
Member Author

shipilev commented Apr 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

Going to push as commit 533fac6.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 31ba7e0: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
  • b96339f: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
  • 261e45a: 8306031: Update IANA Language Subtag Registry to Version 2023-04-13
  • 3764735: 8295026: Remove unused fields in StyleSheet
  • e789a67: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 1b72e51: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • fbcb399: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 9a0e875: 8307411: Test java/foreign/channels/TestAsyncSocketChannels.java failed: IllegalStateException: Already closed
  • e913fa7: 8303457: Introduce convenience test library APIs for creating test servers for tests in test/jdk/java/net/httpclient
  • 7a47adf: 8290126: Add a check in JavadocTester for "javadoc should not crash"
  • ... and 13 more: https://git.openjdk.org/jdk17u-dev/compare/4ececadadd3d75d5468c77ff1fab0723b19ad497...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2024
@openjdk openjdk bot closed this Apr 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@shipilev Pushed as commit 533fac6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants