Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests #2341

Closed
wants to merge 1 commit into from

Conversation

elifaslan1
Copy link
Contributor

@elifaslan1 elifaslan1 commented Mar 27, 2024

Clean backport to unblock parallelism for more hotspot:tier4 tests. in test/hotspot/jtreg/vmTestbase/gc/concurrent tests.
GHA tested.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318727 needs maintainer approval

Issue

  • JDK-8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2341/head:pull/2341
$ git checkout pull/2341

Update a local copy of the PR:
$ git checkout pull/2341
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2341/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2341

View PR using the GUI difftool:
$ git pr show -t 2341

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2341.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 27, 2024

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@elifaslan1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 615c01b: 8297292: java/nio/channels/FileChannel/FileExtensionAndMap.java is too slow
  • 8e132c4: 8163229: several regression tests have a main method that is never executed
  • 7680369: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"
  • e59eeb0: 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test
  • b4e64ff: 8296137: diags-examples.xml is broken
  • b37df14: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC
  • 1e777ec: 8328165: improve assert(idx < _maxlrg) failed: oob
  • 45de685: 8320005: Allow loading of shared objects with .a extension on AIX
  • e82d936: 8328812: Update and move siphash license
  • 4ced080: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/533e1b17939882cd485718e5397c74ff9392d9de...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 29d462a07239a57b83850b9a8662573291fdbdf7 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests Mar 27, 2024
@openjdk
Copy link

openjdk bot commented Mar 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 27, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2024

Webrevs

@elifaslan1
Copy link
Contributor Author

/approval request Clean backport to unblock parallelism for more hotspot:tier4 tests. in test/hotspot/jtreg/vmTestbase/gc/concurrent tests.

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@elifaslan1
8318727: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 27, 2024
@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 28, 2024
@openjdk
Copy link

openjdk bot commented Mar 28, 2024

@elifaslan1
Your change (at version 13118e2) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Apr 2, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

Going to push as commit 78f482d.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 5ecac7a: 8280377: MethodHandleProxies does not correctly invoke default methods with varags
  • 4ececad: 8306714: Open source few Swing event and AbstractAction tests
  • 151091c: 8305942: Open source several AWT Focus related tests
  • 996dfb0: 8305943: Open source few AWT Focus related tests
  • 615c01b: 8297292: java/nio/channels/FileChannel/FileExtensionAndMap.java is too slow
  • 8e132c4: 8163229: several regression tests have a main method that is never executed
  • 7680369: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"
  • e59eeb0: 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test
  • b4e64ff: 8296137: diags-examples.xml is broken
  • b37df14: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC
  • ... and 13 more: https://git.openjdk.org/jdk17u-dev/compare/533e1b17939882cd485718e5397c74ff9392d9de...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 2, 2024
@openjdk openjdk bot closed this Apr 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@shipilev @elifaslan1 Pushed as commit 78f482d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants