Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306714: Open source few Swing event and AbstractAction tests #2352

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Mar 29, 2024

I backport this for parity with 17.0.11-oracle.


Progress

  • JDK-8306714 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306714: Open source few Swing event and AbstractAction tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2352/head:pull/2352
$ git checkout pull/2352

Update a local copy of the PR:
$ git checkout pull/2352
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2352

View PR using the GUI difftool:
$ git pr show -t 2352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2352.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 29, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306714: Open source few Swing event and AbstractAction tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 615c01b: 8297292: java/nio/channels/FileChannel/FileExtensionAndMap.java is too slow
  • 8e132c4: 8163229: several regression tests have a main method that is never executed
  • 7680369: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"
  • e59eeb0: 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test
  • b4e64ff: 8296137: diags-examples.xml is broken
  • b37df14: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC
  • 1e777ec: 8328165: improve assert(idx < _maxlrg) failed: oob
  • 45de685: 8320005: Allow loading of shared objects with .a extension on AIX
  • e82d936: 8328812: Update and move siphash license
  • 4ced080: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/f52725d4dd2c81242d47437e382b053086290097...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 31a73b0d7088d10a5ffb5541d66806a92b681ef9 8306714: Open source few Swing event and AbstractAction tests Mar 29, 2024
@openjdk
Copy link

openjdk bot commented Mar 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 29, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 29, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 1, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

Going to push as commit 4ececad.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 151091c: 8305942: Open source several AWT Focus related tests
  • 996dfb0: 8305943: Open source few AWT Focus related tests
  • 615c01b: 8297292: java/nio/channels/FileChannel/FileExtensionAndMap.java is too slow
  • 8e132c4: 8163229: several regression tests have a main method that is never executed
  • 7680369: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"
  • e59eeb0: 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test
  • b4e64ff: 8296137: diags-examples.xml is broken
  • b37df14: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC
  • 1e777ec: 8328165: improve assert(idx < _maxlrg) failed: oob
  • 45de685: 8320005: Allow loading of shared objects with .a extension on AIX
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/f52725d4dd2c81242d47437e382b053086290097...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 2, 2024
@openjdk openjdk bot closed this Apr 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@luchenlin Pushed as commit 4ececad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant