Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325876: crashes in docker container tests on Linuxppc64le Power8 machines #2366

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Apr 3, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325876 needs maintainer approval

Issue

  • JDK-8325876: crashes in docker container tests on Linuxppc64le Power8 machines (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2366/head:pull/2366
$ git checkout pull/2366

Update a local copy of the PR:
$ git checkout pull/2366
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2366

View PR using the GUI difftool:
$ git pr show -t 2366

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2366.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 3, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325876: crashes in docker container tests on Linuxppc64le Power8 machines

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ba8db1f6d737bf369f1795d03327217186c0cf64 8325876: crashes in docker container tests on Linuxppc64le Power8 machines Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Apr 3, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 3, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 4, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Apr 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

Going to push as commit e789a67.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 1b72e51: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • fbcb399: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 9a0e875: 8307411: Test java/foreign/channels/TestAsyncSocketChannels.java failed: IllegalStateException: Already closed
  • e913fa7: 8303457: Introduce convenience test library APIs for creating test servers for tests in test/jdk/java/net/httpclient
  • 7a47adf: 8290126: Add a check in JavadocTester for "javadoc should not crash"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2024
@openjdk openjdk bot closed this Apr 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@MBaesken Pushed as commit e789a67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant