Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327631: Update IANA Language Subtag Registry to Version 2024-03-07 #2379

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 8, 2024

One of the required updates of meta information.

I had to adapt the file path. Else clean. Probably recognized as such.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8327631 needs maintainer approval

Issue

  • JDK-8327631: Update IANA Language Subtag Registry to Version 2024-03-07 (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2379/head:pull/2379
$ git checkout pull/2379

Update a local copy of the PR:
$ git checkout pull/2379
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2379/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2379

View PR using the GUI difftool:
$ git pr show -t 2379

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2379.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 8, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327631: Update IANA Language Subtag Registry to Version 2024-03-07

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ed9c128: 8329823: RISC-V: Need to sync CPU features with related JVM flags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin GoeLin changed the base branch from master to pr/2378 April 8, 2024 13:39
@GoeLin GoeLin changed the title Goetz backport 8327631 Backport d5b95a0ed38b10ed9f51d20255e06eb38fdd8b82 Apr 9, 2024
@openjdk openjdk bot changed the title Backport d5b95a0ed38b10ed9f51d20255e06eb38fdd8b82 8327631: Update IANA Language Subtag Registry to Version 2024-03-07 Apr 9, 2024
@openjdk
Copy link

openjdk bot commented Apr 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 9, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 9, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 9, 2024

/clean

@openjdk openjdk bot added the clean label Apr 9, 2024
@openjdk
Copy link

openjdk bot commented Apr 9, 2024

@GoeLin This backport pull request is now marked as clean

@openjdk openjdk bot added approval and removed approval labels Apr 9, 2024
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/2378 to master April 11, 2024 09:35
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8327631
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 12, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 16, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 16, 2024

Going to push as commit 7cabe84.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 592e2c6: 8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out
  • 53853c4: 8286311: remove boilerplate from use of runTests
  • cf93baf: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
  • ed9c128: 8329823: RISC-V: Need to sync CPU features with related JVM flags

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 16, 2024
@openjdk openjdk bot closed this Apr 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 16, 2024
@openjdk
Copy link

openjdk bot commented Apr 16, 2024

@GoeLin Pushed as commit 7cabe84.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8327631 branch April 16, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant