Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309527: Improve test proxy performance #2388

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 10, 2024

I backport this for parity with 17.0.12-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8309527 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8309527: Improve test proxy performance (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2388/head:pull/2388
$ git checkout pull/2388

Update a local copy of the PR:
$ git checkout pull/2388
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2388

View PR using the GUI difftool:
$ git pr show -t 2388

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2388.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309527: Improve test proxy performance

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport fadcd6501879af40360b217d2f76ab86a6f55d27 8309527: Improve test proxy performance Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 10, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 10, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 11, 2024

GHA failures: infra issues as "Failed to download action 'https://api.github.com/repos/actions/github-script/zipball/60a0d83039c74a4aee543508d2ffcb1c3799cdea'. Error: Response status code does not indicate success: 500 (Internal Server Error)."
or "Unable to download artifact(s): Failed to ListArtifacts: Received non-retryable error: Failed request: (403) Forbidden: Error from intermediary with HTTP status code 403 "Forbidden""
Unrelated.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 11, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 11, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

Going to push as commit f6c003a.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 99aa1ca: 8309409: Update HttpInputStreamTest and BodyProcessorInputStreamTest to use hg.openjdk.org
  • ca08689: 8304927: Update java/net/httpclient/BasicAuthTest.java to check basic auth over HTTP/2
  • 00a1fe9: 8297695: Fix typos in test/langtools files
  • 1ae82df: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2024
@openjdk openjdk bot closed this Apr 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 11, 2024
@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@GoeLin Pushed as commit f6c003a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant