Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276657: XSLT compiler tries to define a class with empty name #239

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 11, 2022

Simple fix to backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276657: XSLT compiler tries to define a class with empty name

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/239/head:pull/239
$ git checkout pull/239

Update a local copy of the PR:
$ git checkout pull/239
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/239/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 239

View PR using the GUI difftool:
$ git pr show -t 239

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/239.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a093cdddaf5ab88eb84a147e523db5c3e1be54be 8276657: XSLT compiler tries to define a class with empty name Mar 11, 2022
@openjdk
Copy link

openjdk bot commented Mar 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 11, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276657: XSLT compiler tries to define a class with empty name

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 11, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 11, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 11, 2022

Going to push as commit 3c6aecd.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 79cce16: 8276825: hotspot/runtime/SelectionResolution test errors
  • 972dcde: 8276260: (se) Remove java/nio/channels/Selector/Wakeup.java from ProblemList (win)
  • 535511a: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
  • 3b53635: 8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout
  • fb3ccbc: 8274244: ReportOnImportedModuleAnnotation.java fails on rerun
  • e2fa3d3: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines
  • 08084ea: 8274233: Minor cleanup for ToolBox
  • 8197fd4: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform
  • 6dcf10b: 8282509: [exploded image] ResolvedClassTest fails with similar output

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2022
@openjdk openjdk bot closed this Mar 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 11, 2022
@openjdk
Copy link

openjdk bot commented Mar 11, 2022

@GoeLin Pushed as commit 3c6aecd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant