8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path

[amosshi]

Backport of JDK-8263940

• This PR is not clean, while the only difference is we added an additional import to make the compile work.
• So it can be considered as clean

@@ -69,6 +68,7 @@
 import jdk.internal.ref.CleanerFactory;
 import jdk.internal.vm.annotation.Stable;
 import sun.nio.cs.UTF_8;
+import sun.nio.fs.DefaultFileSystemProvider;
 import sun.security.util.SignatureFileVerifier;
 
 import static java.util.zip.ZipConstants64.*;

Testing

• Local: SetDefaultProvider.java - Test results: passed: 1
• Pipeline: All checks have passed
• Testing Machine: SAP nightlies passed on 2024-04-17,19,20
  • java/nio/file/spi/SetDefaultProvider.java: SUCCESSFUL GitHub 📊⏲ - [6,510 msec]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8263940 needs maintainer approval

Issue

• JDK-8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path (Bug - P3 - Approved)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2390/head:pull/2390
$ git checkout pull/2390

Update a local copy of the PR:
$ git checkout pull/2390
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2390/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2390

View PR using the GUI difftool:
$ git pr show -t 2390

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2390.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• f70558d: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
• 9912666: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
• aa9c12b: 8315609: Open source few more swing text/html tests
• 2d27c94: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• c3438a5: 8305874: Open source AWT Key, Text Event related tests
• 94caa64: 8187759: Background not refreshed when painting over a transparent JFrame
• fbd0088: 8306634: Open source AWT Event related tests
• 7d19575: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
• 80273fa: 8316242: Opensource SwingGraphics manual test
• 3f1c854: 8326006: Allow TEST_VM_FLAGLESS to set flagless mode
• ... and 32 more: https://git.openjdk.org/jdk17u-dev/compare/c758755ccabb533f751fca65331b6e83732c2a8f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (025745ea)

[openjdk]

@amosshi
8263940: The approval request has been created successfully.

[RealLucy]

Looks good.

[amosshi]

/approval request "Backporting for parity with 17.0.12-oracle. Un-Clean backport. SAP nightlies passed on 2024-04-17,19,20”

[openjdk]

@amosshi
8263940: The approval request was already up to date.

[amosshi]

/integrate

[openjdk]

Going to push as commit b13cb2f.
Since your change was applied there have been 44 commits pushed to the master branch:

• 3324133: 8318854: [macos14] Running any AWT app prints Secure coding warning
• 10b427d: 8329570: G1: Excessive is_obj_dead_cond calls in verification
• f70558d: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
• 9912666: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
• aa9c12b: 8315609: Open source few more swing text/html tests
• 2d27c94: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• c3438a5: 8305874: Open source AWT Key, Text Event related tests
• 94caa64: 8187759: Background not refreshed when painting over a transparent JFrame
• fbd0088: 8306634: Open source AWT Event related tests
• 7d19575: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
• ... and 34 more: https://git.openjdk.org/jdk17u-dev/compare/c758755ccabb533f751fca65331b6e83732c2a8f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@amosshi Pushed as commit b13cb2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.