8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

[RealCLanger]

Hi all,

This pull request contains a backport of commit fbb424f9 from the openjdk/jdk21u-dev repository.

The commit being backported was authored by Christoph Langer on 11 Apr 2024 and had no reviewers.

Applies clean except for the copyright years in module-info.java. Will mark clean, hence.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325579 needs maintainer approval
• Change requires CSR request JDK-8326482 to be approved

Issues

• JDK-8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket (Bug - P3 - Approved)
• JDK-8326482: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2396/head:pull/2396
$ git checkout pull/2396

Update a local copy of the PR:
$ git checkout pull/2396
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2396/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2396

View PR using the GUI difftool:
$ git pr show -t 2396

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2396.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

• 025969c: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• c3ed264: 8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java
• 47ad3b4: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms
• 51502b9: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• cb15a15: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
• e9a088d: 8331113: createJMHBundle.sh support configurable maven repo mirror
• aea8e4a: 8264322: Generate CDS archive when creating custom JDK image
• b7c7ea0: 8328194: Add a test to check default rendering engine
• 032e87a: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
• 4cec951: 8315889: Open source several Swing HTMLDocument related tests
• ... and 45 more: https://git.openjdk.org/jdk17u-dev/compare/ed9c12809a20b29806eb15f4983c85aef35e1ccb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (15571a30)

[RealCLanger]

/integrate

[openjdk]

Going to push as commit 32bf1f4.
Since your change was applied there have been 55 commits pushed to the master branch:

• 025969c: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• c3ed264: 8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java
• 47ad3b4: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms
• 51502b9: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• cb15a15: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
• e9a088d: 8331113: createJMHBundle.sh support configurable maven repo mirror
• aea8e4a: 8264322: Generate CDS archive when creating custom JDK image
• b7c7ea0: 8328194: Add a test to check default rendering engine
• 032e87a: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
• 4cec951: 8315889: Open source several Swing HTMLDocument related tests
• ... and 45 more: https://git.openjdk.org/jdk17u-dev/compare/ed9c12809a20b29806eb15f4983c85aef35e1ccb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 32bf1f4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.