-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8305874: Open source AWT Key, Text Event related tests #2400
Conversation
👋 Welcome back ashi! A progress list of the required criteria for merging this PR into |
@amosshi This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 29 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request "Backporting for parity with 17.0.12-oracle. No risk, test fix. Clean backport. SAP nightlies passed on 2024-04-17,19,20” |
/integrate |
Going to push as commit c3438a5.
Your commit was automatically rebased without conflicts. |
Backport of JDK-8305874
Testing
DeleteKeyTyped.java
: Test results: passed: 1EscapeKeyTyped.java
: Test results: passed: 1ShiftF10Test.java
: Test results: no tests selectedContainerEventChildTest.java
: Test results: passed: 1InitialTextEventTest.java
: Test results: passed: 12024-04-17,19,20
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2400/head:pull/2400
$ git checkout pull/2400
Update a local copy of the PR:
$ git checkout pull/2400
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2400/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2400
View PR using the GUI difftool:
$ git pr show -t 2400
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2400.diff
Webrev
Link to Webrev Comment