Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326006: Allow TEST_VM_FLAGLESS to set flagless mode #2410

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Apr 12, 2024

Backport of JDK-8326006

Testing

  • Local: Not Applicable.
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-04-17,19,20

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326006 needs maintainer approval

Issue

  • JDK-8326006: Allow TEST_VM_FLAGLESS to set flagless mode (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2410/head:pull/2410
$ git checkout pull/2410

Update a local copy of the PR:
$ git checkout pull/2410
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2410/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2410

View PR using the GUI difftool:
$ git pr show -t 2410

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2410.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326006: Allow TEST_VM_FLAGLESS to set flagless mode

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d10f277bd39bb5ac9bd48939c916de607fef8ace 8326006: Allow TEST_VM_FLAGLESS to set flagless mode Apr 12, 2024
@openjdk
Copy link

openjdk bot commented Apr 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 12, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Apr 21, 2024

/approval request "Backporting for parity with 17.0.12-oracle. No risk, test fix. Clean backport. SAP nightlies passed on 2024-04-17,19,20”

@openjdk
Copy link

openjdk bot commented Apr 21, 2024

@amosshi
8326006: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 21, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Apr 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

Going to push as commit 3f1c854.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 20f2432: 8316154: Opensource JTextArea manual tests
  • fce34e7: 8315824: Open source several Swing Text/HTML related tests
  • cb32c82: 8306067: Open source AWT Graphics,GridBagLayout related tests
  • 776e10a: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line
  • e806430: 8322858: compiler/c2/aarch64/TestFarJump.java fails on AArch64 due to unexpected PrintAssembly output
  • c741b35: 8281658: Add a security category to the java -XshowSettings option
  • 5b656c8: 8319048: Monitor deflation unlink phase prolongs time to safepoint
  • ed419ef: 8318599: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809
  • d4512fe: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer
  • 30a9a21: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
  • ... and 22 more: https://git.openjdk.org/jdk17u-dev/compare/c758755ccabb533f751fca65331b6e83732c2a8f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 23, 2024
@openjdk openjdk bot closed this Apr 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@amosshi Pushed as commit 3f1c854.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8326006 branch April 23, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant