Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations #2417

Closed
wants to merge 3 commits into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Apr 18, 2024

The same issue reproduces for 17u and 21u too if we apply fix for JDK- 8316186 and JDK-8316893 which are both code cleanup/enhancement. So I suggest we backport JDK-8326936 and its followup fix JDK-8330242 to be safe.

Testing

  • The affected jtreg test cases all pass with jdk release built with latest gcc-13 development branch.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316186 needs maintainer approval
  • JDK-8326936 needs maintainer approval
  • JDK-8330242 needs maintainer approval

Issues

  • JDK-8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations (Bug - P4 - Approved)
  • JDK-8316186: RISC-V: Remove PlatformCmpxchg<4> (Enhancement - P5 - Approved)
  • JDK-8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2417/head:pull/2417
$ git checkout pull/2417

Update a local copy of the PR:
$ git checkout pull/2417
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2417/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2417

View PR using the GUI difftool:
$ git pr show -t 2417

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2417.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
8316186: RISC-V: Remove PlatformCmpxchg<4>
8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport a089ed2b9289eeda73bba47ac87e5bc81a4af9dc 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations Apr 18, 2024
@openjdk
Copy link

openjdk bot commented Apr 18, 2024

This backport pull request has now been updated with issue from the original commit.

@zifeihan zifeihan marked this pull request as ready for review April 18, 2024 03:18
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2024
@zifeihan
Copy link
Member Author

/issue add 8316186, 8330242

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@zifeihan
Adding additional issue to issue list: 8316186: RISC-V: Remove PlatformCmpxchg<4>.

Adding additional issue to issue list: 8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp.

@mlbridge
Copy link

mlbridge bot commented Apr 18, 2024

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 18, 2024
@zifeihan
Copy link
Member Author

@RealFYang : Thanks for the review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@zifeihan
Your change (at version 28d230b) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

Going to push as commit 30a9a21.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2024
@openjdk openjdk bot closed this Apr 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@RealFYang @zifeihan Pushed as commit 30a9a21.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants