Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 19, 2024

I backport this for parity with 17.0.12-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322858 needs maintainer approval

Issue

  • JDK-8322858: compiler/c2/aarch64/TestFarJump.java fails on AArch64 due to unexpected PrintAssembly output (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2419/head:pull/2419
$ git checkout pull/2419

Update a local copy of the PR:
$ git checkout pull/2419
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2419/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2419

View PR using the GUI difftool:
$ git pr show -t 2419

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2419.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322858: compiler/c2/aarch64/TestFarJump.java fails on AArch64 due to unexpected PrintAssembly output

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5b656c8: 8319048: Monitor deflation unlink phase prolongs time to safepoint

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 52a6c37558fa970f595067bc1bb5bc2b710c3876 8322858: compiler/c2/aarch64/TestFarJump.java fails on AArch64 due to unexpected PrintAssembly output Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 19, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 19, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 22, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

Going to push as commit e806430.
Since your change was applied there have been 2 commits pushed to the master branch:

  • c741b35: 8281658: Add a security category to the java -XshowSettings option
  • 5b656c8: 8319048: Monitor deflation unlink phase prolongs time to safepoint

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 22, 2024
@openjdk openjdk bot closed this Apr 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@GoeLin Pushed as commit e806430.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant