8329570: G1: Excessive is_obj_dead_cond calls in verification

[shipilev]

Unclean backport to improve fastdebug build performance, which improves testing. The code shape in JDK 17 is different, I reapplied the hunks in places relevant to JDK 17.

Additional testing:

• GHA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8329570 needs maintainer approval

Issue

• JDK-8329570: G1: Excessive is_obj_dead_cond calls in verification (Enhancement - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2425/head:pull/2425
$ git checkout pull/2425

Update a local copy of the PR:
$ git checkout pull/2425
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2425/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2425

View PR using the GUI difftool:
$ git pr show -t 2425

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2425.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329570: G1: Excessive is_obj_dead_cond calls in verification

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• f70558d: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
• 9912666: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
• aa9c12b: 8315609: Open source few more swing text/html tests
• 2d27c94: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• c3438a5: 8305874: Open source AWT Key, Text Event related tests
• 94caa64: 8187759: Background not refreshed when painting over a transparent JFrame
• fbd0088: 8306634: Open source AWT Event related tests
• 7d19575: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
• 80273fa: 8316242: Opensource SwingGraphics manual test
• 3f1c854: 8326006: Allow TEST_VM_FLAGLESS to set flagless mode
• ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/5b656c86e87bfb3e227ff48ab654ea957b9bc2e0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (9bb28d41)
• 00: Full (56104f5b)

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request Simple fastdebug performance improvement fix. GHA tests pass. Risk is low, as it only moves the assert to an earlier stage.

[openjdk]

@shipilev
8329570: The approval request has been created successfully.

[shipilev]

/integrate

[openjdk]

Going to push as commit 10b427d.
Since your change was applied there have been 16 commits pushed to the master branch:

• f70558d: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
• 9912666: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
• aa9c12b: 8315609: Open source few more swing text/html tests
• 2d27c94: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• c3438a5: 8305874: Open source AWT Key, Text Event related tests
• 94caa64: 8187759: Background not refreshed when painting over a transparent JFrame
• fbd0088: 8306634: Open source AWT Event related tests
• 7d19575: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
• 80273fa: 8316242: Opensource SwingGraphics manual test
• 3f1c854: 8326006: Allow TEST_VM_FLAGLESS to set flagless mode
• ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/5b656c86e87bfb3e227ff48ab654ea957b9bc2e0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 10b427d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.