Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331113: createJMHBundle.sh support configurable maven repo mirror #2428

Closed

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Apr 26, 2024

Hi,
Clean backport of JDK-8331113 for createJMHBundle.sh support configurable maven repo mirror.
Only change devkit shell script, no risk.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331113 needs maintainer approval

Issue

  • JDK-8331113: createJMHBundle.sh support configurable maven repo mirror (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2428/head:pull/2428
$ git checkout pull/2428

Update a local copy of the PR:
$ git checkout pull/2428
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2428/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2428

View PR using the GUI difftool:
$ git pr show -t 2428

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2428.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331113: createJMHBundle.sh support configurable maven repo mirror

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 032e87a: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
  • 4cec951: 8315889: Open source several Swing HTMLDocument related tests
  • 52d1f0c: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 9682314: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64
  • 71630eb: 8327989: java/net/httpclient/ManyRequest.java should not use "localhost" in URIs
  • e51f176: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
  • 9b2f521: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols
  • 54e0120: 8301753: AppendFile/WriteFile has differences between make 3.81 and 4+
  • 3f5e536: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
  • bcc83cd: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ce9eac38191fa700afa3ac06b2b202576a11dd71 8331113: createJMHBundle.sh support configurable maven repo mirror Apr 26, 2024
@openjdk
Copy link

openjdk bot commented Apr 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Apr 26, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2024

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Apr 26, 2024

Please check the GHA tests!

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the approval label Apr 26, 2024
@sendaoYan
Copy link
Member Author

Please check the GHA tests!

@GoeLin It seems a intermittent failure of TestMetaspacePerfCounters.java. I rerun the failed job and it's successed.

For the intermittent failure, I create new PR, which backport of JDK-8293503

@sendaoYan
Copy link
Member Author

/approval request Clean backport of JDK-8331113, no risk.

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

@sendaoYan
8331113: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 26, 2024
@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 29, 2024
@openjdk
Copy link

openjdk bot commented Apr 29, 2024

@sendaoYan
Your change (at version 9d65f8f) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

1 similar comment
@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

Going to push as commit e9a088d.
Since your change was applied there have been 12 commits pushed to the master branch:

  • aea8e4a: 8264322: Generate CDS archive when creating custom JDK image
  • b7c7ea0: 8328194: Add a test to check default rendering engine
  • 032e87a: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
  • 4cec951: 8315889: Open source several Swing HTMLDocument related tests
  • 52d1f0c: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 9682314: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64
  • 71630eb: 8327989: java/net/httpclient/ManyRequest.java should not use "localhost" in URIs
  • e51f176: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
  • 9b2f521: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols
  • 54e0120: 8301753: AppendFile/WriteFile has differences between make 3.81 and 4+
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/b13cb2f5db0ba178a1fcee54aa3209acdeb33e30...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2024
@openjdk openjdk bot closed this Apr 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 29, 2024
@openjdk
Copy link

openjdk bot commented Apr 29, 2024

@shipilev @sendaoYan Pushed as commit e9a088d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

@shipilev The command sponsor can only be used in open pull requests.

@sendaoYan
Copy link
Member Author

/sponsor

@GoeLin @shipilev Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants