-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size #2430
8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size #2430
Conversation
/approval request Fixes Epsilon performance problem, corner-case with clear test. Applies cleanly. New regression test fails without the fix, passes with it. Other Epsilon tests pass as well. There is no bugtail after a month in mainline. |
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/integrate |
Going to push as commit 51502b9.
Your commit was automatically rebased without conflicts. |
Fixes Epsilon performance problem, corner-case with clear test.
Additional testing:
gc/epsilon
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2430/head:pull/2430
$ git checkout pull/2430
Update a local copy of the PR:
$ git checkout pull/2430
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2430/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2430
View PR using the GUI difftool:
$ git pr show -t 2430
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2430.diff
Webrev
Link to Webrev Comment