Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293503: gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 failed assertGreaterThanOrEqual: expected MMM >= NNN #2431

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Apr 26, 2024

Hi,
Backport of JDK-8293503, to fix the intermittent failure of TestMetaspacePerfCounters.java.
This PR add a proper barrier inbetween two measurements. Only change the testcase, the change has been verify on below binary:

  • linux x64 release
  • linux x64 fastdebug
  • linux x86 release
  • linux x86 fastdebug

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8293503 needs maintainer approval

Issue

  • JDK-8293503: gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 failed assertGreaterThanOrEqual: expected MMM >= NNN (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2431/head:pull/2431
$ git checkout pull/2431

Update a local copy of the PR:
$ git checkout pull/2431
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2431/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2431

View PR using the GUI difftool:
$ git pr show -t 2431

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2431.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 04d7b7d5747d887e12797df8ca3f7608d73d41ff 8293503: gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 failed assertGreaterThanOrEqual: expected MMM >= NNN Apr 26, 2024
@openjdk
Copy link

openjdk bot commented Apr 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 26, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 26, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2024

Webrevs

@openjdk openjdk bot added the approval label Apr 26, 2024
@tstuefe
Copy link
Member

tstuefe commented Apr 26, 2024

Since this is not a clean backport, which part of it is not clean?

@sendaoYan
Copy link
Member Author

Since this is not a clean backport, which part of it is not clean?

@tstuefe Hello

There are two part of it's not clean:

  1. Before JDK-8293503, this file has prefixed PR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests, it remove jvm option -XX:+IgnoreUnrecognizedVMOptions, and split all the test config to 32 bit and 64 bit, because 32bit jvm doesn't support option -XX:-UseCompressedClassPointers. Maybe I should backport this patch before backport of JDK-8293503, or ignore this patch? I think this patch is useful.
  2. The original JDK-8293503 delete gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 8293503 generic-all in test/hotspot/jtreg/ProblemList.txt. It's not needed to to in jdk17u-dev.

@sendaoYan
Copy link
Member Author

Since this is not a clean backport, which part of it is not clean?

@tstuefe Hello

There are two part of it's not clean:

  1. Before JDK-8293503, this file has prefixed PR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests, it remove jvm option -XX:+IgnoreUnrecognizedVMOptions, and split all the test config to 32 bit and 64 bit, because 32bit jvm doesn't support option -XX:-UseCompressedClassPointers. Maybe I should backport this patch before backport of JDK-8293503, or ignore this patch? I think this patch is useful.
  2. The original JDK-8293503 delete gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 8293503 generic-all in test/hotspot/jtreg/ProblemList.txt. It's not needed to to in jdk17u-dev.

I creat a new PR for the prefixed backport JDK-8290023

@openjdk openjdk bot removed the approval label May 2, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Wait until #2438 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants