8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests #2438

sendaoYan · 2024-04-28T09:55:01Z

Hi,
This is backport of JDK-8290023 and JDK-8290269, this PR is prefixed PR of backport
JDK-8293503

Only change the testcase, additional testing:

jtreg tier1/tier2/tier3 etc. tests on linux x64 release build
jtreg tier1/tier2/tier3 etc. tests on linux x64 fastdebug build
jtreg tier1/tier2/tier3 etc. tests on linux aarch64 release build
jtreg tier1/tier2/tier3 etc. tests on linux aarch64 fastdebug build

It's not clean backport:

test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR 8210708 before 8290023 jdk20
There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev
test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported 8298073 and 8241293 after 8290023 in jdk17u-dev
test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR 8284161 before 8290023 in jdk20

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8290269 needs maintainer approval
JDK-8290023 needs maintainer approval

Issues

JDK-8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests (Enhancement - P4 - Approved)
JDK-8290269: gc/shenandoah/TestVerifyJCStress.java fails due to invalid tag: required after JDK-8290023 (Bug - P4 - Approved)

Reviewers

Paul Hohensee (@phohensee - Reviewer) 🔄 Re-review required (review applies to 98df7caf)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2438/head:pull/2438
$ git checkout pull/2438

Update a local copy of the PR:
$ git checkout pull/2438
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2438

View PR using the GUI difftool:
$ git pr show -t 2438

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2438.diff

Webrev

Link to Webrev Comment

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>

bridgekeeper · 2024-04-28T09:55:21Z

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-04-28T09:56:12Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

openjdk · 2024-04-28T09:56:20Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2024-04-28T09:59:27Z

Webrevs

bridgekeeper · 2024-06-10T10:10:30Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-06-10T12:58:32Z

Hi, can anyone review this PR.

bridgekeeper · 2024-07-08T13:50:42Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-07-08T14:42:48Z

/open

openjdk · 2024-07-08T14:44:19Z

@sendaoYan This pull request is already open

sendaoYan · 2024-07-31T14:00:22Z

/open

openjdk · 2024-07-31T14:01:40Z

@sendaoYan This pull request is already open

bridgekeeper · 2024-08-28T14:09:44Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-08-28T15:27:43Z

/approval request Backport to remove unnecessary use of IgnoreUnrecognizedVMOptions in gc tests, test fix only, the change has been verified, no risk.

openjdk · 2024-08-28T15:28:54Z

@sendaoYan
8290023: The approval request has been created successfully.

GoeLin · 2024-08-29T13:28:48Z

Hi Sendao,
please only label for approval if you have a review.
I will only approve reviewed changes, but there is no way I can filter for this.
So I revisit changes labeled for approval but not reviewed every time I do approvals, badly wasting my time.
I will remove the fix-request labels next time I visit changes not reviewed. You can label again once a review is there.
Thanks.

sendaoYan · 2024-08-29T15:38:48Z

/approval cancel

openjdk · 2024-08-29T15:39:34Z

@sendaoYan
8290023: The approval request has been cancelled successfully.

sendaoYan · 2024-08-29T15:43:15Z

Hi Sendao, please only label for approval if you have a review. I will only approve reviewed changes, but there is no way I can filter for this. So I revisit changes labeled for approval but not reviewed every time I do approvals, badly wasting my time. I will remove the fix-request labels next time I visit changes not reviewed. You can label again once a review is there. Thanks.

Sorry for that. I will cancel approval of all the PRs which have not been review yet.
Sorry.

phohensee

Please remove copyright date updates that are not in the original commit, and use the latest copyright dates from the original commit rather than 2024.

…/gc/metaspace/TestMetaspacePerfCounters.java

sendaoYan · 2024-09-03T15:42:36Z

Please remove copyright date updates that are not in the original commit, and use the latest copyright dates from the original commit rather than 2024.

Thanks for the review. The copyright mis-updates has been reverted.

…JCStress.java

…JCStress.java with an empty line

phohensee

Thank you. Ltgm.

openjdk · 2024-09-03T17:00:21Z

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

…ion: Invalid tag: required"

sendaoYan · 2024-09-04T01:12:20Z

Thank you. Ltgm.

In JDK-8290023, there is a typo bug, which has been fixed by JDK-8290269, I think we should include backport of JDK-8290269 in this PR, the backport commit is 4e02. Can you review this PR again, thanks.

sendaoYan · 2024-09-04T01:13:44Z

/issue JDK-8290269

openjdk · 2024-09-04T01:14:42Z

@sendaoYan
Adding additional issue to issue list: 8290269: gc/shenandoah/TestVerifyJCStress.java fails due to invalid tag: required after JDK-8290023.

bridgekeeper · 2024-10-02T05:17:24Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-10-02T15:47:10Z

/open

openjdk · 2024-10-02T15:48:44Z

@sendaoYan This pull request is already open

Backport 2583feb21bf5419afc3c1953d964cf89d65fe8a2

6228279

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>

openjdk bot changed the title ~~Backport 2583feb21bf5419afc3c1953d964cf89d65fe8a2~~ 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests Apr 28, 2024

openjdk bot added backport rfr Pull request is ready for review labels Apr 28, 2024

sendaoYan mentioned this pull request Apr 28, 2024

8293503: gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 failed assertGreaterThanOrEqual: expected MMM >= NNN #2431

Draft

8 tasks

Merge branch 'openjdk:master' into jbs8290023

13b8a71

openjdk bot added the approval label Aug 28, 2024

openjdk bot removed the approval label Aug 29, 2024

Merge branch 'openjdk:master' into jbs8290023

a0e75cb

phohensee suggested changes Sep 3, 2024

View reviewed changes

sendaoYan added 2 commits September 3, 2024 23:33

revert the change of copyright year

7e86a2f

use the origin copyright year of backported PR for test/hotspot/jtreg…

c4925b1

…/gc/metaspace/TestMetaspacePerfCounters.java

sendaoYan added 2 commits September 3, 2024 23:52

implement the backport of test/hotspot/jtreg/gc/shenandoah/TestVerify…

7bdea88

…JCStress.java

implement the backport of test/hotspot/jtreg/gc/shenandoah/TestVerify…

98df7ca

…JCStress.java with an empty line

sendaoYan requested a review from phohensee September 3, 2024 15:58

phohensee approved these changes Sep 3, 2024

View reviewed changes

backport JDK-8290269, to fix error: "TEST RESULT: Error. Parse Except…

4e0213b

…ion: Invalid tag: required"

sendaoYan requested a review from phohensee September 4, 2024 01:12

openjdk bot added approval and removed approval labels Oct 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests #2438

8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests #2438

sendaoYan commented Apr 28, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 28, 2024

openjdk bot commented Apr 28, 2024

openjdk bot commented Apr 28, 2024

mlbridge bot commented Apr 28, 2024 •

edited

Loading

bridgekeeper bot commented Jun 10, 2024

sendaoYan commented Jun 10, 2024

bridgekeeper bot commented Jul 8, 2024

sendaoYan commented Jul 8, 2024

openjdk bot commented Jul 8, 2024

sendaoYan commented Jul 31, 2024

openjdk bot commented Jul 31, 2024

bridgekeeper bot commented Aug 28, 2024

sendaoYan commented Aug 28, 2024

openjdk bot commented Aug 28, 2024

GoeLin commented Aug 29, 2024

sendaoYan commented Aug 29, 2024

openjdk bot commented Aug 29, 2024

sendaoYan commented Aug 29, 2024

phohensee left a comment

sendaoYan commented Sep 3, 2024

phohensee left a comment

openjdk bot commented Sep 3, 2024

sendaoYan commented Sep 4, 2024 •

edited

Loading

sendaoYan commented Sep 4, 2024

openjdk bot commented Sep 4, 2024

bridgekeeper bot commented Oct 2, 2024

sendaoYan commented Oct 2, 2024

openjdk bot commented Oct 2, 2024

8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests #2438

Are you sure you want to change the base?

8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests #2438

Conversation

sendaoYan commented Apr 28, 2024 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Apr 28, 2024

openjdk bot commented Apr 28, 2024

openjdk bot commented Apr 28, 2024

mlbridge bot commented Apr 28, 2024 • edited Loading

Webrevs

bridgekeeper bot commented Jun 10, 2024

sendaoYan commented Jun 10, 2024

bridgekeeper bot commented Jul 8, 2024

sendaoYan commented Jul 8, 2024

openjdk bot commented Jul 8, 2024

sendaoYan commented Jul 31, 2024

openjdk bot commented Jul 31, 2024

bridgekeeper bot commented Aug 28, 2024

sendaoYan commented Aug 28, 2024

openjdk bot commented Aug 28, 2024

GoeLin commented Aug 29, 2024

sendaoYan commented Aug 29, 2024

openjdk bot commented Aug 29, 2024

sendaoYan commented Aug 29, 2024

phohensee left a comment

Choose a reason for hiding this comment

sendaoYan commented Sep 3, 2024

phohensee left a comment

Choose a reason for hiding this comment

openjdk bot commented Sep 3, 2024

sendaoYan commented Sep 4, 2024 • edited Loading

sendaoYan commented Sep 4, 2024

openjdk bot commented Sep 4, 2024

bridgekeeper bot commented Oct 2, 2024

sendaoYan commented Oct 2, 2024

openjdk bot commented Oct 2, 2024

sendaoYan commented Apr 28, 2024 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 28, 2024 •

edited

Loading

sendaoYan commented Sep 4, 2024 •

edited

Loading