Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java #2439

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Apr 29, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8272916 needs maintainer approval

Issue

  • JDK-8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2439/head:pull/2439
$ git checkout pull/2439

Update a local copy of the PR:
$ git checkout pull/2439
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2439/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2439

View PR using the GUI difftool:
$ git pr show -t 2439

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2439.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 29, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 51502b9: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
  • cb15a15: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
  • e9a088d: 8331113: createJMHBundle.sh support configurable maven repo mirror

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c547ead493fafb6716550996a83276afc0ec018a 8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java Apr 29, 2024
@openjdk
Copy link

openjdk bot commented Apr 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 29, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 29, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 29, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 30, 2024

Going to push as commit c3ed264.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 47ad3b4: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms
  • 51502b9: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
  • cb15a15: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
  • e9a088d: 8331113: createJMHBundle.sh support configurable maven repo mirror

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 30, 2024
@openjdk openjdk bot closed this Apr 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 30, 2024
@openjdk
Copy link

openjdk bot commented Apr 30, 2024

@MBaesken Pushed as commit c3ed264.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant