Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8330094: RISC-V: Save and restore FRM in the call stub #2442

Closed
wants to merge 1 commit into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Apr 30, 2024

Hi, The same issue also exists in JDK17u. So I would like to backport JDK-8330094 to jdk17u-dev. With this change, we save and restore the default floating-point control state when we enter and leave Java code, ensuring that we are still Java compatible if we're called via the JNI invocation interface with a weird FP control state. RISC-V specific change, risk is low.
The backport is not clean because jdk17u-dev only has partial vector api instruct, this backport-related instruct does not exist in jdk17u-dev.

Testing

  • Run tier1-3 tests on SOPHON SG2042 (release)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330094 needs maintainer approval

Issue

  • JDK-8330094: RISC-V: Save and restore FRM in the call stub (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2442/head:pull/2442
$ git checkout pull/2442

Update a local copy of the PR:
$ git checkout pull/2442
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2442

View PR using the GUI difftool:
$ git pr show -t 2442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2442.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 30, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 30, 2024

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330094: RISC-V: Save and restore FRM in the call stub

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 32bf1f4: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • 025969c: 8326521: JFR: CompilerPhase event test fails on windows 32 bit

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport b0496096dc8d7dc7acf28aa006141a3ecea446de 8330094: RISC-V: Save and restore FRM in the call stub Apr 30, 2024
@openjdk
Copy link

openjdk bot commented Apr 30, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 30, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 30, 2024

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented May 1, 2024

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 1, 2024
@zifeihan
Copy link
Member Author

zifeihan commented May 4, 2024

@RealFYang : Thanks for the review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 4, 2024
@openjdk
Copy link

openjdk bot commented May 4, 2024

@zifeihan
Your change (at version 3007c78) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 5, 2024

Going to push as commit 68a2d93.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 32bf1f4: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • 025969c: 8326521: JFR: CompilerPhase event test fails on windows 32 bit

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 5, 2024
@openjdk openjdk bot closed this May 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 5, 2024
@openjdk
Copy link

openjdk bot commented May 5, 2024

@RealFYang @zifeihan Pushed as commit 68a2d93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants