8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space

[offamitkumar]

Hi all,

This pull request contains a backport of commit d5f3d5c8 from the openjdk/jdk repository.

The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8326201 needs maintainer approval

Issue

• JDK-8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space (Bug - P3 - Approved)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2446/head:pull/2446
$ git checkout pull/2446

Update a local copy of the PR:
$ git checkout pull/2446
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2446/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2446

View PR using the GUI difftool:
$ git pr show -t 2446

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2446.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 16579f8: 8297445: PPC64: Represent Registers as values
• 20c2511: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition
• 8f68f8f: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
• 4504b16: 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed
• 97cc177: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
• e552509: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
• 5a3c668: 8272315: Improve assert_different_registers
• e974897: 8298413: [s390] CPUInfoTest fails due to uppercase feature string
• d2982c6: 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11
• 68a2d93: 8330094: RISC-V: Save and restore FRM in the call stub
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/025969c97e8b6dc600d2935c4225d04dae6e23bf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealLucy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (e77090d8)

[offamitkumar]

@RealLucy due to copyright changes diff, I think, this one didn't get marked clean. Would you please review it :-)

[RealLucy]

Looks good.

[openjdk]

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[offamitkumar]

/approval request bug is present in jdk17 as well. I have performed the testing and result is good. Only s390x specific change so other platforms are fine. Risk is low.

[openjdk]

@offamitkumar
8326201: The approval request has been created successfully.

[offamitkumar]

Thank you @RealLucy for review.

/integrate

[openjdk]

@offamitkumar
Your change (at version e77090d) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 606c542.
Since your change was applied there have been 11 commits pushed to the master branch:

• 16579f8: 8297445: PPC64: Represent Registers as values
• 20c2511: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition
• 8f68f8f: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
• 4504b16: 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed
• 97cc177: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
• e552509: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
• 5a3c668: 8272315: Improve assert_different_registers
• e974897: 8298413: [s390] CPUInfoTest fails due to uppercase feature string
• d2982c6: 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11
• 68a2d93: 8330094: RISC-V: Save and restore FRM in the call stub
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/025969c97e8b6dc600d2935c4225d04dae6e23bf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @offamitkumar Pushed as commit 606c542.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.