Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list #2451

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 8, 2024

Hi all,

This pull request contains a backport of 012dafee from the openjdk/jdk21u-dev repository.

It did not apply since in jdk17u-dev the test was problemlisted with another bugid.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8297082 needs maintainer approval

Issue

  • JDK-8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list (Sub-task - P5 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2451/head:pull/2451
$ git checkout pull/2451

Update a local copy of the PR:
$ git checkout pull/2451
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2451/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2451

View PR using the GUI difftool:
$ git pr show -t 2451

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2451.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 8, 2024

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 012dafee5bc035a2eb27ac5efab9658ade92bf90 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list May 8, 2024
@openjdk
Copy link

openjdk bot commented May 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 8, 2024

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented May 8, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 8, 2024
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 9, 2024

Going to push as commit e552509.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 5a3c668: 8272315: Improve assert_different_registers
  • e974897: 8298413: [s390] CPUInfoTest fails due to uppercase feature string

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 9, 2024
@openjdk openjdk bot closed this May 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 9, 2024
@openjdk
Copy link

openjdk bot commented May 9, 2024

@RealCLanger Pushed as commit e552509.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the backport-RealCLanger-012dafee branch May 9, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants