8307423: [s390x] Represent Registers as values

[offamitkumar]

Hi all,

This pull request contains a backport of commit 8bbd264c from the openjdk/jdk repository.

The commit being backported was authored by Amit Kumar on 8 May 2023 and was reviewed by Martin Doerr and Lutz Schmidt.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8307423 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8307423: [s390x] Represent Registers as values (Enhancement - P3 - Approved)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer) ⚠️ Review applies to 23939e02

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2453/head:pull/2453
$ git checkout pull/2453

Update a local copy of the PR:
$ git checkout pull/2453
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2453

View PR using the GUI difftool:
$ git pr show -t 2453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2453.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307423: [s390x] Represent Registers as values

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• bf4b15c: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
• ce1fb02: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
• 606c542: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealLucy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full (087530a1)
• 00: Full (23939e02)

[offamitkumar]

I ran tier1 test and no new failure appeared.

@RealLucy please review. Initially it was clean patch but I had to delete register_definitions_s390.cpp and following that a minor change in vmStruct.cpp.

[RealLucy]

Looks good.
A lot of tedious work! Thank you.

[openjdk]

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[offamitkumar]

/approval request backporting this change as we are getting warnings while build jdk17 with gcc-11.4, Performed tier1 and no new failure appeared.

[openjdk]

@offamitkumar
8307423: The approval request has been created successfully.

[TheRealMDoerr]

Please merge and make sure the change in vmStructs.cpp works on both platforms: NOT_S390( NOT_PPC64(. Thanks!

[offamitkumar]

I ran tier1 test again after the code change, on fastdebug build. Result is good there and GHA also looks good.

Thanks @RealLucy for review and Martin in resolving merge conflict :-)

/integrate

[openjdk]

@offamitkumar
Your change (at version 087530a) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit f789e38.
Since your change was applied there have been 3 commits pushed to the master branch:

• bf4b15c: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
• ce1fb02: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
• 606c542: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @offamitkumar Pushed as commit f789e38.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.