-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297445: PPC64: Represent Registers as values #2454
8297445: PPC64: Represent Registers as values #2454
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request This backport fixes build warnings with GCC 11 as described in JDK-8297426. It doesn't apply cleanly, but resolution was simple and has been reviewed. The original change didn't cause any regression. The backport has been tested in our nightly tests. |
@TheRealMDoerr |
/integrate |
Going to push as commit 16579f8.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 16579f8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8297445. Fixes GCC 11 build warnings (JDK-8297426).
Backport requires manual integration mainly due to unrelated context differences, but is easy to resolve.
One hunk in templateTable_ppc_64.cpp (monitorenter, 0f2da83) is already there.
Some obsolete stuff needs to get removed (see 2nd commit).
RegisterImpl::number_of_registers
is not an important constant for the SA. The x86 version of this change simply removed it (declare_constant(RegisterImpl::number_of_registers)
): openjdk/jdk@755ecf6I have kept it for the platforms which didn't backport the change. (x86 doesn't need the backport for GCC 11.)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2454/head:pull/2454
$ git checkout pull/2454
Update a local copy of the PR:
$ git checkout pull/2454
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2454/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2454
View PR using the GUI difftool:
$ git pr show -t 2454
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2454.diff
Webrev
Link to Webrev Comment