Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297445: PPC64: Represent Registers as values #2454

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented May 9, 2024

Backport of JDK-8297445. Fixes GCC 11 build warnings (JDK-8297426).

Backport requires manual integration mainly due to unrelated context differences, but is easy to resolve.
One hunk in templateTable_ppc_64.cpp (monitorenter, 0f2da83) is already there.

Some obsolete stuff needs to get removed (see 2nd commit). RegisterImpl::number_of_registers is not an important constant for the SA. The x86 version of this change simply removed it (declare_constant(RegisterImpl::number_of_registers)): openjdk/jdk@755ecf6
I have kept it for the platforms which didn't backport the change. (x86 doesn't need the backport for GCC 11.)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8297445 needs maintainer approval

Issue

  • JDK-8297445: PPC64: Represent Registers as values (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2454/head:pull/2454
$ git checkout pull/2454

Update a local copy of the PR:
$ git checkout pull/2454
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2454/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2454

View PR using the GUI difftool:
$ git pr show -t 2454

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2454.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 9, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297445: PPC64: Represent Registers as values

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 20c2511: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition
  • 8f68f8f: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • 4504b16: 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed
  • 97cc177: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
  • e552509: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 9, 2024
@TheRealMDoerr TheRealMDoerr changed the title 8297445 ppc64 registers as values 8297445: PPC64: Represent Registers as values May 9, 2024
@TheRealMDoerr TheRealMDoerr changed the title 8297445: PPC64: Represent Registers as values Backport 9c77e41b81ebd28bd92ea7adad605981a5519046 May 9, 2024
@openjdk openjdk bot changed the title Backport 9c77e41b81ebd28bd92ea7adad605981a5519046 8297445: PPC64: Represent Registers as values May 9, 2024
@openjdk
Copy link

openjdk bot commented May 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 9, 2024
@mlbridge
Copy link

mlbridge bot commented May 9, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented May 10, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@TheRealMDoerr
Copy link
Contributor Author

/approval request This backport fixes build warnings with GCC 11 as described in JDK-8297426. It doesn't apply cleanly, but resolution was simple and has been reviewed. The original change didn't cause any regression. The backport has been tested in our nightly tests.

@openjdk
Copy link

openjdk bot commented May 10, 2024

@TheRealMDoerr
8297445: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 10, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 13, 2024

Going to push as commit 16579f8.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 20c2511: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition
  • 8f68f8f: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • 4504b16: 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed
  • 97cc177: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
  • e552509: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 13, 2024
@openjdk openjdk bot closed this May 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2024
@TheRealMDoerr TheRealMDoerr deleted the 8297445_PPC64_Registers_as_values branch May 13, 2024 10:41
@openjdk
Copy link

openjdk bot commented May 13, 2024

@TheRealMDoerr Pushed as commit 16579f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants