Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError #2457

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented May 13, 2024

I backport this for parity with 17.0.12-oracle.


Progress

  • JDK-8267796 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2457/head:pull/2457
$ git checkout pull/2457

Update a local copy of the PR:
$ git checkout pull/2457
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2457/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2457

View PR using the GUI difftool:
$ git pr show -t 2457

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2457.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • e2791f3: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect
  • f789e38: 8307423: [s390x] Represent Registers as values
  • bf4b15c: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
  • ce1fb02: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • 606c542: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • 16579f8: 8297445: PPC64: Represent Registers as values
  • 20c2511: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition
  • 8f68f8f: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • 4504b16: 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed
  • 97cc177: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/5a3c668646c363f2a2028e4aede63eef524ad5fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f12200cd11c2b689618cde1902db941ee23fbf80 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 13, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 13, 2024
@mlbridge
Copy link

mlbridge bot commented May 13, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 14, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented May 14, 2024

Going to push as commit 8f0fa10.
Since your change was applied there have been 11 commits pushed to the master branch:

  • e2791f3: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect
  • f789e38: 8307423: [s390x] Represent Registers as values
  • bf4b15c: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
  • ce1fb02: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • 606c542: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • 16579f8: 8297445: PPC64: Represent Registers as values
  • 20c2511: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition
  • 8f68f8f: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • 4504b16: 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed
  • 97cc177: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/5a3c668646c363f2a2028e4aede63eef524ad5fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 14, 2024
@openjdk openjdk bot closed this May 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

@luchenlin Pushed as commit 8f0fa10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant