8305819: LogConfigurationTest intermittently fails on AArch64

[mmyxym]

Hi all,

This pull request contains a backport of commit 911cc7cb from the openjdk/jdk repository.

It fixed a logging crash due to arm weak memory model.

The commit being backported was authored by gaogao-mem on 15 May 2023 and was reviewed by Andrew Haley, David Holmes and Xin Liu.

The conflicts only come from the difference of "NULL" and "nullptr".

Additional testing:

• Verified the test case in original PR.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8305819 needs maintainer approval

Issue

• JDK-8305819: LogConfigurationTest intermittently fails on AArch64 (Bug - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2460/head:pull/2460
$ git checkout pull/2460

Update a local copy of the PR:
$ git checkout pull/2460
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2460

View PR using the GUI difftool:
$ git pr show -t 2460

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2460.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mmyxym This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305819: LogConfigurationTest intermittently fails on AArch64

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• db04c7b: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
• 68caeca: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used
• d2b9c01: 8302907: [PPC64] Use more constexpr in class Register
• e0dba38: 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy
• 8f0fa10: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError
• e2791f3: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect
• f789e38: 8307423: [s390x] Represent Registers as values
• bf4b15c: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
• ce1fb02: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
• 606c542: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/20c2511f54bbae0d41f8750f5e02c6b59630d66f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (1acc4480)

[TheRealMDoerr]

LGTM.

[openjdk]

⚠️ @mmyxym This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mmyxym]

/approval request backport of fixing crash due to weak memory model. Conflicts come from the difference of "NULL" and "nullptr". Risk is very low.

[openjdk]

@mmyxym
8305819: The approval request has been created successfully.

[mmyxym]

/integrate

[openjdk]

@mmyxym
Your change (at version 1acc448) is now ready to be sponsored by a Committer.

[mmyxym]

Could committers please help to sponsor?

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 18bb8da.
Since your change was applied there have been 12 commits pushed to the master branch:

• 0a3445e: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
• db04c7b: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
• 68caeca: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used
• d2b9c01: 8302907: [PPC64] Use more constexpr in class Register
• e0dba38: 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy
• 8f0fa10: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError
• e2791f3: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect
• f789e38: 8307423: [s390x] Represent Registers as values
• bf4b15c: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
• ce1fb02: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/20c2511f54bbae0d41f8750f5e02c6b59630d66f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @mmyxym Pushed as commit 18bb8da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.