Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8302907: [PPC64] Use more constexpr in class Register #2461

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented May 13, 2024

Clean backport of JDK-8302907.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8302907 needs maintainer approval

Issue

  • JDK-8302907: [PPC64] Use more constexpr in class Register (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2461/head:pull/2461
$ git checkout pull/2461

Update a local copy of the PR:
$ git checkout pull/2461
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2461/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2461

View PR using the GUI difftool:
$ git pr show -t 2461

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2461.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302907: [PPC64] Use more constexpr in class Register

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • e2791f3: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect
  • f789e38: 8307423: [s390x] Represent Registers as values
  • bf4b15c: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
  • ce1fb02: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • 606c542: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 180b94c73e9ad17d57650d4c985d4104289052a9 8302907: [PPC64] Use more constexpr in class Register May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 13, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 13, 2024
@mlbridge
Copy link

mlbridge bot commented May 13, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

GHA failure is unrelated. This PR only touches one PPC64 file.

@TheRealMDoerr
Copy link
Contributor Author

/approval request This is a follow-up change for JDK-8297445 which is already backported. This one is needed for some later changes. We should have it in order to be prepared for future backports. It's trivial and applies cleanly. SAP's testing has passed.

@openjdk
Copy link

openjdk bot commented May 13, 2024

@TheRealMDoerr
8302907: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 13, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 14, 2024

Going to push as commit d2b9c01.
Since your change was applied there have been 7 commits pushed to the master branch:

  • e0dba38: 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy
  • 8f0fa10: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError
  • e2791f3: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect
  • f789e38: 8307423: [s390x] Represent Registers as values
  • bf4b15c: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
  • ce1fb02: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • 606c542: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 14, 2024
@openjdk openjdk bot closed this May 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

@TheRealMDoerr Pushed as commit d2b9c01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant