Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8330815: Use pattern matching for instanceof in KeepAliveCache #2464

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 13, 2024

Nearly clean backport from 21u-dev, only copyright conflicts.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330815 needs maintainer approval

Issue

  • JDK-8330815: Use pattern matching for instanceof in KeepAliveCache (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2464/head:pull/2464
$ git checkout pull/2464

Update a local copy of the PR:
$ git checkout pull/2464
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2464/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2464

View PR using the GUI difftool:
$ git pr show -t 2464

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2464.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2024

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330815: Use pattern matching for instanceof in KeepAliveCache

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 261ad5e: 8331352: error: template-id not allowed for constructor/destructor in C++20
  • d17fa03: 8328997: Remove unnecessary template parameter lists in GrowableArray
  • 2440b24: 8319268: Build failure with GCC8.3.1 after 8313643
  • 98038b3: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
  • 18bb8da: 8305819: LogConfigurationTest intermittently fails on AArch64
  • 0a3445e: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
  • db04c7b: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
  • 68caeca: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used
  • d2b9c01: 8302907: [PPC64] Use more constexpr in class Register
  • e0dba38: 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/bf4b15ce080bfdf1dd818233cd1ef6ac0519294d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ddecbe52018fdb7556b04b20e8529eb430d3aa75 8330815: Use pattern matching for instanceof in KeepAliveCache May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 13, 2024

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 13, 2024
@mlbridge
Copy link

mlbridge bot commented May 13, 2024

Webrevs

@openjdk openjdk bot added the approval label May 14, 2024
@RealCLanger
Copy link
Contributor Author

macos-x64 build issue seems infrastructure related.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 16, 2024
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2024

Going to push as commit fed9693.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 261ad5e: 8331352: error: template-id not allowed for constructor/destructor in C++20
  • d17fa03: 8328997: Remove unnecessary template parameter lists in GrowableArray
  • 2440b24: 8319268: Build failure with GCC8.3.1 after 8313643
  • 98038b3: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
  • 18bb8da: 8305819: LogConfigurationTest intermittently fails on AArch64
  • 0a3445e: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
  • db04c7b: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
  • 68caeca: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used
  • d2b9c01: 8302907: [PPC64] Use more constexpr in class Register
  • e0dba38: 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/bf4b15ce080bfdf1dd818233cd1ef6ac0519294d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2024
@openjdk openjdk bot closed this May 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2024
@openjdk
Copy link

openjdk bot commented May 16, 2024

@RealCLanger Pushed as commit fed9693.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the backport-RealCLanger-ddecbe52 branch May 16, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant