8324243: Compilation failures in java.desktop module with gcc 14

[jankratochvil]

It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64).
It needs all of JDK-8328997 (backport), JDK-8331352 (backport) and JDK-8324243 (this backport).
Git cherry-pick was not clean but it was easy to apply.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8324243 needs maintainer approval

Issue

• JDK-8324243: Compilation failures in java.desktop module with gcc 14 (Bug - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2468/head:pull/2468
$ git checkout pull/2468

Update a local copy of the PR:
$ git checkout pull/2468
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2468/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2468

View PR using the GUI difftool:
$ git pr show -t 2468

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2468.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324243: Compilation failures in java.desktop module with gcc 14

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• fed9693: 8330815: Use pattern matching for instanceof in KeepAliveCache

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (bd9788c5)
• 01: Full (0c19f678)
• 00: Full (1e2cba09)

[TheRealMDoerr]

Can you include openjdk/jdk@ec79ab4, please, such that the code looks like the upstream version?
And consider using "/issue add JDK-8319268". GCC8 should still be supported.

[jankratochvil]

I would like to backport it separately. The list of versions affected is different and moreover I do not have the problem reproducible. I have tried devtoolset-8-gcc-8.3.1-3.2.el7.x86_64 (CentOS-7) and gcc-8.3.0.tar.xz (rebuilt from source). I have tried to build this branch https://github.com/jankratochvil/jdk17u-dev/tree/8324243 .
Filed as #2475 .

[TheRealMDoerr]

Even better. Thanks! This should make this backport clean and no longer require a review. And it will make future backports which touch this code clean, too.

[jankratochvil]

Now it should look like: openjdk/jdk@8e5f6dd
It was later reformatted a bit but that is a different patch: openjdk/jdk@d292aab#diff-c75e2d581b3730cf900075cedb66ac72eaba40fbbd92eaac5710161830b572b4

[TheRealMDoerr]

Thanks! Looks good, now.

[jankratochvil]

/integrate

[openjdk]

@jankratochvil This pull request has not yet been marked as ready for integration.

[jankratochvil]

/integrate

[openjdk]

@jankratochvil
Your change (at version bd9788c) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 0e524e2.
Since your change was applied there has been 1 commit pushed to the master branch:

• fed9693: 8330815: Use pattern matching for instanceof in KeepAliveCache

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @jankratochvil Pushed as commit 0e524e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.