Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all #2469

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented May 14, 2024

Hi all,
This is backport of JDK-8331466. This backport is not clean because the line number of 8227120 has changed from 115 to 137, and it's a previous problemlist for aix-ppc64. Only change the Problemlist.txt, the risk is low.

Thanks
sendao


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331466 needs maintainer approval

Issue

  • JDK-8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2469/head:pull/2469
$ git checkout pull/2469

Update a local copy of the PR:
$ git checkout pull/2469
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2469

View PR using the GUI difftool:
$ git pr show -t 2469

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2469.diff

Webrev

Link to Webrev Comment

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 229 new commits pushed to the master branch:

  • 4c58e1b: 8325754: Dead AbstractQueuedSynchronizer$ConditionNodes survive minor garbage collections
  • cfe714b: 8325194: GHA: Add macOS M1 testing
  • 05bea0e: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test
  • 7dcb608: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS
  • c915eaf: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots
  • 3d83f3e: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads
  • 1e63af9: 8300806: Update googletest to v1.13.0
  • e809008: 8300910: Remove metaprogramming/integralConstant.hpp
  • 952d272: 8300265: Remove metaprogramming/isSigned.hpp
  • f9acc53: 8300260: Remove metaprogramming/isSame.hpp
  • ... and 219 more: https://git.openjdk.org/jdk17u-dev/compare/e2791f3304768729fbc665886f9c406fb3d1bf39...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 440782e0160f867f08afbec0abf48d557a522c72 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 14, 2024
@mlbridge
Copy link

mlbridge bot commented May 14, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 11, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval request Backport of JDK-8331466, only change the Problemlist.txt, no risk.

@openjdk
Copy link

openjdk bot commented Jun 11, 2024

@sendaoYan
8331466: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Jun 11, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented Jun 12, 2024

Thanks for the approved.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@sendaoYan This pull request has not yet been marked as ready for integration.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Hi, can anyone take a look this PR.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 11, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approved.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 12, 2024
@openjdk
Copy link

openjdk bot commented Jul 12, 2024

@sendaoYan
Your change (at version b0674c3) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 12, 2024

Going to push as commit 61e2dba.
Since your change was applied there have been 232 commits pushed to the master branch:

  • 5ad9e24: 8280994: [XWayland] Drag and Drop does not work in java -> wayland app direction
  • 1242055: 8309703: AIX build fails after JDK-8280982
  • 55bbe06: 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2
  • 4c58e1b: 8325754: Dead AbstractQueuedSynchronizer$ConditionNodes survive minor garbage collections
  • cfe714b: 8325194: GHA: Add macOS M1 testing
  • 05bea0e: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test
  • 7dcb608: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS
  • c915eaf: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots
  • 3d83f3e: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads
  • 1e63af9: 8300806: Update googletest to v1.13.0
  • ... and 222 more: https://git.openjdk.org/jdk17u-dev/compare/e2791f3304768729fbc665886f9c406fb3d1bf39...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 12, 2024
@openjdk openjdk bot closed this Jul 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 12, 2024
@openjdk
Copy link

openjdk bot commented Jul 12, 2024

@phohensee @sendaoYan Pushed as commit 61e2dba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8331466 branch July 13, 2024 01:12
@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants