Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272168: some hotspot runtime/logging tests don't check exit code #247

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 14, 2022

I backport this for parity with 17.0.4-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272168: some hotspot runtime/logging tests don't check exit code

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/247/head:pull/247
$ git checkout pull/247

Update a local copy of the PR:
$ git checkout pull/247
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/247/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 247

View PR using the GUI difftool:
$ git pr show -t 247

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/247.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 14, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3b899ef7ffd87477ac1b10f4334b127597e9fe32 8272168: some hotspot runtime/logging tests don't check exit code Mar 14, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 14, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272168: some hotspot runtime/logging tests don't check exit code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 14, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 14, 2022

Webrevs

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Mar 15, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2022

Going to push as commit 88216d8.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 16f7508: 8269077: TestSystemGC uses "require vm.gc.G1" for large pages subtest
  • d4d3348: 8267163: Rename anonymous loader tests to hidden loader tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 15, 2022
@openjdk openjdk bot closed this Mar 15, 2022
@openjdk openjdk bot removed ready rfr labels Mar 15, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2022

@GoeLin Pushed as commit 88216d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant