Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314835: gtest wrappers should be marked as flagless #2470

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented May 14, 2024

Hi all,
This is backport of JDK-8314835, to make releated tests as flagless.
The backport is not clean, because the file test/hotspot/jtreg/gtest/NativeHeapTrimmerGtest.java has subsequent backport JDK-8325496
Only change the testcases, the risk is low.

Thanks,
-sendao


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314835 needs maintainer approval

Issue

  • JDK-8314835: gtest wrappers should be marked as flagless (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2470/head:pull/2470
$ git checkout pull/2470

Update a local copy of the PR:
$ git checkout pull/2470
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2470/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2470

View PR using the GUI difftool:
$ git pr show -t 2470

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2470.diff

Webrev

Link to Webrev Comment

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314835: gtest wrappers should be marked as flagless

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 6c3a188: 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS
  • 060c250: 8177107: Reduce memory footprint of java.lang.reflect.Constructor/Method
  • 4071b8c: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
  • a640001: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • a632247: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC
  • e00211b: 8321107: Add more test cases for JDK-8319372
  • 6264c70: 8273153: Consolidate file_exists into os:file_exists
  • 95f8dc0: 8316138: Add GlobalSign 2 TLS root certificates
  • 0e524e2: 8324243: Compilation failures in java.desktop module with gcc 14
  • fed9693: 8330815: Use pattern matching for instanceof in KeepAliveCache
  • ... and 11 more: https://git.openjdk.org/jdk17u-dev/compare/e2791f3304768729fbc665886f9c406fb3d1bf39...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 1ea6463fbb95258725ed4a11621ec662859a76e0 8314835: gtest wrappers should be marked as flagless May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 14, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 14, 2024
@sendaoYan
Copy link
Member Author

/approval request Backport of JDK-8314835, to make releated tests as flagless. Only change the testcases, the risk is low.

@mlbridge
Copy link

mlbridge bot commented May 14, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented May 14, 2024

@sendaoYan
8314835: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 14, 2024
@RealCLanger
Copy link
Contributor

@sendaoYan would you consider to integrate this today to have it in 17.0.12?

@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@sendaoYan
Your change (at version d4e7617) is now ready to be sponsored by a Committer.

@sendaoYan
Copy link
Member Author

@sendaoYan would you consider to integrate this today to have it in 17.0.12?

Sorry, I did not notice that the jdk17u-fix-yes label has been added. Integrate right now.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 28, 2024

Going to push as commit 69e6736.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 6c3a188: 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS
  • 060c250: 8177107: Reduce memory footprint of java.lang.reflect.Constructor/Method
  • 4071b8c: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
  • a640001: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • a632247: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC
  • e00211b: 8321107: Add more test cases for JDK-8319372
  • 6264c70: 8273153: Consolidate file_exists into os:file_exists
  • 95f8dc0: 8316138: Add GlobalSign 2 TLS root certificates
  • 0e524e2: 8324243: Compilation failures in java.desktop module with gcc 14
  • fed9693: 8330815: Use pattern matching for instanceof in KeepAliveCache
  • ... and 11 more: https://git.openjdk.org/jdk17u-dev/compare/e2791f3304768729fbc665886f9c406fb3d1bf39...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2024
@openjdk openjdk bot closed this May 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@RealCLanger @sendaoYan Pushed as commit 69e6736.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8314835 branch May 28, 2024 06:09
@sendaoYan
Copy link
Member Author

/sponsor

Thanks.

@tstuefe
Copy link
Member

tstuefe commented May 28, 2024

Hi, about this and similar "flagless" backports. Why is this backported, and how does it affect test execution? What does flagless do, exactly?

@sendaoYan
Copy link
Member Author

Hi, about this and similar "flagless" backports. Why is this backported, and how does it affect test execution? What does flagless do, exactly?

If the testcase mark as @requires vm.flagless, then this testcase will not been selected by jtreg when gived jvm non-default jvm options. That means this testcase not suitable for run with non-default jvm options.

Take gtest/AsyncLogGtest.java as an example:
Do jtreg list with default jvm options:

> jtreg -l test/hotspot/jtreg/gtest/AsyncLogGtest.java
Testsuite: /home/yansendao/git/jdk/test/hotspot/jtreg
gtest/AsyncLogGtest.java
Tests found: 1

Do jtreg list with jvm options -Xcomp, it says not tests found:

> jtreg -l -Xcomp test/hotspot/jtreg/gtest/AsyncLogGtest.java
Testsuite: /home/yansendao/git/jdk/test/hotspot/jtreg
Tests found: 0

The testcases which mark as @requires vm.flagless not suitable for run with non-default jvm options, that means these testcases will only run with default jvm options. These testcases will run failed when it's not mark as @requires vm.flagless when run with some non-default jvm options. The "flagless" backport make these testcases more robustness.

@tstuefe
Copy link
Member

tstuefe commented May 28, 2024

Hi, about this and similar "flagless" backports. Why is this backported, and how does it affect test execution? What does flagless do, exactly?

If the testcase mark as @requires vm.flagless, then this testcase will not been selected by jtreg when gived jvm non-default jvm options. That means this testcase not suitable for run with non-default jvm options.

Take gtest/AsyncLogGtest.java as an example: Do jtreg list with default jvm options:

> jtreg -l test/hotspot/jtreg/gtest/AsyncLogGtest.java
Testsuite: /home/yansendao/git/jdk/test/hotspot/jtreg
gtest/AsyncLogGtest.java
Tests found: 1

Do jtreg list with jvm options -Xcomp, it says not tests found:

> jtreg -l -Xcomp test/hotspot/jtreg/gtest/AsyncLogGtest.java
Testsuite: /home/yansendao/git/jdk/test/hotspot/jtreg
Tests found: 0

The testcases which mark as @requires vm.flagless not suitable for run with non-default jvm options, that means these testcases will only run with default jvm options. These testcases will run failed when it's not mark as @requires vm.flagless when run with some non-default jvm options. The "flagless" backport make these testcases more robustness.

Interesting, thanks for the clear and concise explanation! BTW, I was not aware that one could give VM options directly to jtreg. Is jtreg -XX:+abc" the same as jtreg '-vmoption=-XX:abc'` ?

I also realize that these questions should have been raised at the original PR.

I guess the "flagless" concept assumes that there is always a standard run with no options, and only additional runs specify options. If you want to always specify certain options, e.g. certain paranoia flags, or increase logging, this would unexpectedly omit a bunch of tests.

@sendaoYan
Copy link
Member Author

I think jtreg -XX:+abc same as jtreg -vmoption:"-XX:+abc"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants