8316138: Add GlobalSign 2 TLS root certificates

[Delawen]

Backport for https://bugs.openjdk.org/browse/JDK-8316138

Related to openjdk/jdk21u-dev#581

Changes since the original commit: the checksum for the certificates and the folder where the certs are stored.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8316138 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8316138: Add GlobalSign 2 TLS root certificates (Enhancement - P3 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2479/head:pull/2479
$ git checkout pull/2479

Update a local copy of the PR:
$ git checkout pull/2479
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2479/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2479

View PR using the GUI difftool:
$ git pr show -t 2479

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2479.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Delawen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Delawen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316138: Add GlobalSign 2 TLS root certificates

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 0e524e2: 8324243: Compilation failures in java.desktop module with gcc 14
• fed9693: 8330815: Use pattern matching for instanceof in KeepAliveCache
• 261ad5e: 8331352: error: template-id not allowed for constructor/destructor in C++20
• d17fa03: 8328997: Remove unnecessary template parameter lists in GrowableArray
• 2440b24: 8319268: Build failure with GCC8.3.1 after 8313643

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[Delawen]

@TheRealMDoerr redid #2478 because force pushing does not suit well with the jdk bot :) But here we are.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[Delawen]

/approval JDK-8316138 request Fix Request
This is a backport for https://bugs.openjdk.org/browse/JDK-8316138 It includes two new certificates for cacert. The original commit placed them in a different folder, which is not the right one for this JDK version. It also updates the test that checks certificates are in place, updating the checksum.

[openjdk]

@Delawen
JDK-8316138: The approval request has been created successfully.

[Delawen]

$ make test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java"
Building target 'test' in configuration 'linux-x86_64-server-release'
Creating jdk image
Creating CDS archive for jdk image
Creating CDS-NOCOOPS archive for jdk image
Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run:
* jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java'
Passed: sun/security/lib/cacerts/VerifyCACerts.java
Test results: passed: 1
Report written to /home/delawen/git/jdk17u-dev/build/linux-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html
Results written to /home/delawen/git/jdk17u-dev/build/linux-x86_64-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java
Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java'
Test report is stored in build/linux-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java
                                                         1     1     0     0   
==============================
TEST SUCCESS

Finished building target 'test' in configuration 'linux-x86_64-server-release'

[Delawen]

@jerboaa Here is the backport of the certificates for JDK17

[TheRealMDoerr]

LGTM. Thanks for backporting it! We want to ship it with 17.0.12.

[mlbridge]

Webrevs

• 00: Full (f89e7175)

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8316138: The approval request has been approved.

[Delawen]

/integrate

[openjdk]

@Delawen
Your change (at version f89e717) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 95f8dc0.
Since your change was applied there have been 5 commits pushed to the master branch:

• 0e524e2: 8324243: Compilation failures in java.desktop module with gcc 14
• fed9693: 8330815: Use pattern matching for instanceof in KeepAliveCache
• 261ad5e: 8331352: error: template-id not allowed for constructor/destructor in C++20
• d17fa03: 8328997: Remove unnecessary template parameter lists in GrowableArray
• 2440b24: 8319268: Build failure with GCC8.3.1 after 8313643

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @Delawen Pushed as commit 95f8dc0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.