Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 #2482

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented May 20, 2024

I backport this for parity with 17.0.12-oracle.
This PR contains a backport of
openjdk/jdk@5045839
Patch is not clean, this file test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java has changed by the commit
openjdk/jdk@d52a995
, I ignored this commits and only change code for this issue.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8323635 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2482/head:pull/2482
$ git checkout pull/2482

Update a local copy of the PR:
$ git checkout pull/2482
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2482/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2482

View PR using the GUI difftool:
$ git pr show -t 2482

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2482.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 20, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 5045839cb2095105a5c6c9eebc633a78b1e3213e 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 May 20, 2024
@openjdk
Copy link

openjdk bot commented May 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 20, 2024
@mlbridge
Copy link

mlbridge bot commented May 20, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor

TheRealMDoerr commented May 23, 2024

Is JDK17 affected by this problem?
make run-test TEST="test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java" JTREG="VM_OPTIONS=-XX:TieredStopAtLevel=3 has passed without the fix:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java
                                                         1     1     0     0   
==============================
TEST SUCCESS

@luchenlin
Copy link
Author

Not reproduced in 17. We can reopen it if needed.

1 similar comment
@luchenlin
Copy link
Author

Not reproduced in 17. We can reopen it if needed.

@luchenlin luchenlin closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants