Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8177107: Reduce memory footprint of java.lang.reflect.Constructor/Method #2486

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented May 21, 2024

Clean backport to improve memory footprint in reflection-heavy applications.

Additional testing:

  • Linux AArch64 server fastdebug, java/lang/reflect
  • Linux x86_64 server fastdebug, all

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8177107 needs maintainer approval

Issue

  • JDK-8177107: Reduce memory footprint of java.lang.reflect.Constructor/Method (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2486/head:pull/2486
$ git checkout pull/2486

Update a local copy of the PR:
$ git checkout pull/2486
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2486/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2486

View PR using the GUI difftool:
$ git pr show -t 2486

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2486.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 21, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8177107: Reduce memory footprint of java.lang.reflect.Constructor/Method

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

  • 95f8dc0: 8316138: Add GlobalSign 2 TLS root certificates
  • 0e524e2: 8324243: Compilation failures in java.desktop module with gcc 14
  • fed9693: 8330815: Use pattern matching for instanceof in KeepAliveCache
  • 261ad5e: 8331352: error: template-id not allowed for constructor/destructor in C++20
  • d17fa03: 8328997: Remove unnecessary template parameter lists in GrowableArray
  • 2440b24: 8319268: Build failure with GCC8.3.1 after 8313643
  • 98038b3: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
  • 18bb8da: 8305819: LogConfigurationTest intermittently fails on AArch64
  • 0a3445e: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
  • db04c7b: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
  • ... and 35 more: https://git.openjdk.org/jdk17u-dev/compare/54e012001e593596c12b117af766e1adb0c03fef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a385142398eee102ff1a53d848230dc95c4ebd37 8177107: Reduce memory footprint of java.lang.reflect.Constructor/Method May 21, 2024
@openjdk
Copy link

openjdk bot commented May 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 21, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 21, 2024
@mlbridge
Copy link

mlbridge bot commented May 21, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to improve memory footprint in reflection-heavy applications. All tests pass. Was in mainline and releases for 2 years without bug tail. Risk is low-medium: touches the production code, but in a simple manner.

@openjdk
Copy link

openjdk bot commented May 22, 2024

@shipilev
8177107: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 22, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 27, 2024

Going to push as commit 060c250.
Since your change was applied there have been 50 commits pushed to the master branch:

  • 4071b8c: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
  • a640001: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • a632247: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC
  • e00211b: 8321107: Add more test cases for JDK-8319372
  • 6264c70: 8273153: Consolidate file_exists into os:file_exists
  • 95f8dc0: 8316138: Add GlobalSign 2 TLS root certificates
  • 0e524e2: 8324243: Compilation failures in java.desktop module with gcc 14
  • fed9693: 8330815: Use pattern matching for instanceof in KeepAliveCache
  • 261ad5e: 8331352: error: template-id not allowed for constructor/destructor in C++20
  • d17fa03: 8328997: Remove unnecessary template parameter lists in GrowableArray
  • ... and 40 more: https://git.openjdk.org/jdk17u-dev/compare/54e012001e593596c12b117af766e1adb0c03fef...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 27, 2024
@openjdk openjdk bot closed this May 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2024
@openjdk
Copy link

openjdk bot commented May 27, 2024

@shipilev Pushed as commit 060c250.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant